Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2389233003: PS whitelisting - removed a TODO (Closed)

Created:
4 years, 2 months ago by Ivan Šandrk
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PS whitelisting - removed a TODO There's no need to add a comment for every entry saying "no apparent privacy implications - no further thoughts", absence of comments is a reasonable indicator of this (clarified with mnissler over email). BUG=650672 Committed: https://crrev.com/d04de4c5a7a78993944fcb0006b947fe6b020371 Cr-Commit-Position: refs/heads/master@{#423134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ivan Šandrk
Hi Drew, cosmetic fix, ptal! Thanks, Ivan
4 years, 2 months ago (2016-10-05 12:13:38 UTC) #3
Andrew T Wilson (Slow)
lgtm
4 years, 2 months ago (2016-10-05 12:21:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389233003/1
4 years, 2 months ago (2016-10-05 12:21:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 12:45:29 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 12:47:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d04de4c5a7a78993944fcb0006b947fe6b020371
Cr-Commit-Position: refs/heads/master@{#423134}

Powered by Google App Engine
This is Rietveld 408576698