LayoutTests/http/tests/htmlimports/import-dup-custom-element.html - Issue 238923009: HTML Imports: No more BlockingDocumentCreation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/htmlimports/import-dup-custom-element.html

Issue 238923009: HTML Imports: No more BlockingDocumentCreation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed the build breakage Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/html/imports/resources/nest-dup-child.html ('k') | LayoutTests/http/tests/htmlimports/import-dup-custom-element-expected.txt » ('j') | LayoutTests/http/tests/htmlimports/resources/custom-element-def.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/testharness.js"></script>

	5 <script src="../../../resources/testharnessreport.js"></script>

	6 <script>

	7 var records = [];

	8

	9 function addRecord(str)

	10 {

	11 console.log(str);

	12 records.push(str);

	13 }

	14

	15 function recordElement(element)

	16 {

	17 addRecord(element.tagName + ":" + element.id);

	18 }

	19 </script>

	20 <my-custom id="using-toplevel-1"></my-custom>

	21 <!--

	22 -- \|using-custom-element-1.html\| reaches \|def-custom-element.html\| with one in direction
	dominicc (has gone to gerrit) 2014/04/18 00:56:25 in direction -> indirection? in direction -> indirection? dominicc (has gone to gerrit) 2014/04/18 00:56:25 I'm not crazy about the -- prefixes. Just left ali I'm not crazy about the -- prefixes. Just left align and enjoy the extra four character line length. Hajime Morrita 2014/04/18 01:48:33 Rietveld wraps it badly. The real code doesn't hav Show quoted text On 2014/04/18 00:56:25, dominicc wrote: > in direction -> indirection? Rietveld wraps it badly. The real code doesn't have no space here. Hajime Morrita 2014/04/18 01:48:33 Done. Show quoted text On 2014/04/18 00:56:25, dominicc wrote: > I'm not crazy about the -- prefixes. Just left align and enjoy the extra four > character line length. Done.
	23 -- while \|using-custom-element-2.html\| imports it directly.

	24 -- So \|using-custom-element-2.html\| triggers importing \|def-custom-element.htm l\| and

	25 -- \|using-custom-element-1.html\| finds it and de-dups later.

	26 -->

	27 <link rel="import" href="resources/using-custom-element-1.html">

	28 <link rel="import" href="resources/using-custom-element-2.html">

	29 <my-custom id="using-toplevel-2"></my-custom>

	30 </head>

	31 <body>

	32 <script>

	33 test(function () {

	34 assert_array_equals(records, ['MY-CUSTOM:using-toplevel-1',

	35 'MY-CUSTOM:using-1-before',

	36 'MY-CUSTOM:pointing-before',

	37 'MY-CUSTOM:def-before',

	38 'MY-CUSTOM:def-after',

	39 'MY-CUSTOM:pointing-after',

	40 'MY-CUSTOM:using-1-after',

	41 'MY-CUSTOM:using-2-before',

	42 'MY-CUSTOM:using-2-after',

	43 'MY-CUSTOM:using-toplevel-2'],

	44 'Custom Element invocations preserve tree order across im ports');

	45 }, 'Custom Element invocations preserve tree order across imports regardless the loading order.');

	46 </script>

	47 </body>

	48 </html>

OLD	NEW