PPAPI: Format ppapi/thunk using clang-format.

PPAPI: Format ppapi/thunk using clang-format.

BUG=345417
R=teravest@chromium.org

Committed: https://crrev.com/ffb1cc0ce7dc5ef0facb1306120f36faec64f4f0
Cr-Commit-Position: refs/heads/master@{#303308}

[teravest, 2014-04-16 15:19:16]

Some of the indentation still looks pretty bad.

https://codereview.chromium.org/238923007/diff/20001/ppapi/generators/idl_out...
File ppapi/generators/idl_outfile.py (right):

https://codereview.chromium.org/238923007/diff/20001/ppapi/generators/idl_out...
ppapi/generators/idl_outfile.py:99: (new_output, err) =
clang_format.communicate("".join(self.outlist))
Since you don't use the error output, this is more idiomatic:
new_output, _ = clang_format.communicate("".join(self.outlist))

https://codereview.chromium.org/238923007/diff/20001/ppapi/thunk/ppb_alarms_d...
File ppapi/thunk/ppb_alarms_dev_thunk.cc (right):

https://codereview.chromium.org/238923007/diff/20001/ppapi/thunk/ppb_alarms_d...
ppapi/thunk/ppb_alarms_dev_thunk.cc:63: &Create, &Get, &GetAll, &Clear,
&ClearAll, &AddOnAlarmListener};
I'd prefer that all of these still got their own lines.
But I suppose I could deal with this if that's a hassle.

https://codereview.chromium.org/238923007/diff/20001/ppapi/thunk/ppb_audio_co...
File ppapi/thunk/ppb_audio_config_thunk.cc (right):

https://codereview.chromium.org/238923007/diff/20001/ppapi/thunk/ppb_audio_co...
ppapi/thunk/ppb_audio_config_thunk.cc:76: &CreateStereo16bit,
&RecommendSampleFrameCount_1_0, &IsAudioConfig,
:(

[dmichael (off chromium), 2014-04-16 21:59:15]

As we discussed offline, I decided to leave the files that aren't generated
alone for now. If people touch them in CLs, they may have to run the formatter
later, and they can force line breaks if appropriate then.

https://codereview.chromium.org/238923007/diff/20001/ppapi/generators/idl_out...
File ppapi/generators/idl_outfile.py (right):

https://codereview.chromium.org/238923007/diff/20001/ppapi/generators/idl_out...
ppapi/generators/idl_outfile.py:99: (new_output, err) =
clang_format.communicate("".join(self.outlist))
On 2014/04/16 15:19:16, teravest wrote:
> Since you don't use the error output, this is more idiomatic:
> new_output, _ = clang_format.communicate("".join(self.outlist))

Oops, thanks. That was a holdover from my guess-and-test style of python
debugging. I've seen other places in Chromium just use [0], so I did that.

[dmichael (off chromium), 2014-04-16 22:00:32]

On 2014/04/16 21:59:15, dmichael wrote:
> As we discussed offline, I decided to leave the files that aren't generated
> alone for now. If people touch them in CLs, they may have to run the formatter
> later, and they can force line breaks if appropriate then.
To clarify...  I left alone *thunk* files that are not generated. I ran
clang-format on:
1) All generated thunk files, and
2) C++ files in ppapi/thunk that are not thunk files.
> 
>
https://codereview.chromium.org/238923007/diff/20001/ppapi/generators/idl_out...
> File ppapi/generators/idl_outfile.py (right):
> 
>
https://codereview.chromium.org/238923007/diff/20001/ppapi/generators/idl_out...
> ppapi/generators/idl_outfile.py:99: (new_output, err) =
> clang_format.communicate("".join(self.outlist))
> On 2014/04/16 15:19:16, teravest wrote:
> > Since you don't use the error output, this is more idiomatic:
> > new_output, _ = clang_format.communicate("".join(self.outlist))
> 
> Oops, thanks. That was a holdover from my guess-and-test style of python
> debugging. I've seen other places in Chromium just use [0], so I did that.

[teravest, 2014-04-17 14:00:50]

lgtm

https://codereview.chromium.org/238923007/diff/80001/ppapi/generators/idl_thu...
File ppapi/generators/idl_thunk.py (right):

https://codereview.chromium.org/238923007/diff/80001/ppapi/generators/idl_thu...
ppapi/generators/idl_thunk.py:541: out.Write(',  //\n'.join(['  &%s' % f for f
in generated_functions]))
It'd be nice to have a comment here saying what these empty comments are for.

[dmichael (off chromium), 2014-04-17 16:58:07]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-04-17 16:58:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/238923007/110001

[commit-bot: I haz the power, 2014-04-17 17:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-17 17:53:57]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Nico, 2014-04-17 18:37:35]

https://codereview.chromium.org/238923007/diff/80001/ppapi/thunk/ppb_url_load...
File ppapi/thunk/ppb_url_loader_thunk.cc (right):

https://codereview.chromium.org/238923007/diff/80001/ppapi/thunk/ppb_url_load...
ppapi/thunk/ppb_url_loader_thunk.cc:130: &Close                                 
           //
Eww, that's pretty horrible, no?

Have you tried if this is better with the just-updated clang-format that today's
"gclient sync" will get you?

[dmichael (off chromium), 2014-04-17 19:11:12]

https://codereview.chromium.org/238923007/diff/80001/ppapi/thunk/ppb_url_load...
File ppapi/thunk/ppb_url_loader_thunk.cc (right):

https://codereview.chromium.org/238923007/diff/80001/ppapi/thunk/ppb_url_load...
ppapi/thunk/ppb_url_loader_thunk.cc:130: &Close                                 
           //
On 2014/04/17 18:37:36, Nico wrote:
> Eww, that's pretty horrible, no?
Yes, exactly why I had filed that bug...  thank you for helping me with that!

> 
> Have you tried if this is better with the just-updated clang-format that
today's
> "gclient sync" will get you?
No, I misunderstood and thought it wasn't going to get resolved the way I had
hoped. Thanks, I'll do that before landing, since the CQ rejected this anyway.

[dmichael (off chromium), 2014-04-17 19:25:17]

On 2014/04/17 19:11:12, dmichael wrote:
>
https://codereview.chromium.org/238923007/diff/80001/ppapi/thunk/ppb_url_load...
> File ppapi/thunk/ppb_url_loader_thunk.cc (right):
> 
>
https://codereview.chromium.org/238923007/diff/80001/ppapi/thunk/ppb_url_load...
> ppapi/thunk/ppb_url_loader_thunk.cc:130: &Close                               
 
>            //
> On 2014/04/17 18:37:36, Nico wrote:
> > Eww, that's pretty horrible, no?
> Yes, exactly why I had filed that bug...  thank you for helping me with that!
> 
> > 
> > Have you tried if this is better with the just-updated clang-format that
> today's
> > "gclient sync" will get you?
> No, I misunderstood and thought it wasn't going to get resolved the way I had
> hoped. Thanks, I'll do that before landing, since the CQ rejected this anyway.
The current rev of clang-format that's DEPSed in appears to be 206068, while the
fix for this was at 206458.

Maybe I should just hold off until the next roll; this isn't urgent. I'm just
trying to move all of Pepper over to clang-format as a background task.

[teravest, 2014-05-07 14:15:51]

Has clang format been rolled yet?

[Nico, 2014-05-07 14:50:44]

Not sure which revision you're waiting for, but clang-format --help (or was
it --version) print the revision it's at. It's rolled every now and then,
the last for about 3 weeks ago.
On May 7, 2014 7:15 AM, <teravest@chromium.org> wrote:

> Has clang format been rolled yet?
>
>
> https://codereview.chromium.org/238923007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmichael (off chromium), 2014-05-07 15:11:54]

This CL is waiting on 206458, we appear to be at 206068 right now.

[teravest, 2014-11-07 16:06:20]

On 2014/05/07 15:11:54, dmichael wrote:
> This CL is waiting on 206458, we appear to be at 206068 right now.

$ ../../depot_tools/clang-format --version
clang-format version 3.6.0 (218404)

[dmichael (off chromium), 2014-11-07 17:18:42]

Patchset #9 (id:150001) has been deleted

[dmichael (off chromium), 2014-11-07 17:19:20]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-11-07 17:19:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/238923007/170001

[commit-bot: I haz the power, 2014-11-07 17:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 17:24:43]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/78881)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dmichael (off chromium), 2014-11-07 21:54:37]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-11-07 21:55:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/238923007/190001

[commit-bot: I haz the power, 2014-11-07 22:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 22:01:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmichael (off chromium), 2014-11-07 22:19:52]

Committed patchset #10 (id:190001) manually as
ffb1cc0ce7dc5ef0facb1306120f36faec64f4f0 (presubmit successful).

[commit-bot: I haz the power, 2014-11-07 22:20:02]

Patchset 10 (id:??) landed as
https://crrev.com/ffb1cc0ce7dc5ef0facb1306120f36faec64f4f0
Cr-Commit-Position: refs/heads/master@{#303308}