Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 23892020: GTTF: Make --help and --gtest_help behave correctly with --brave-new-test-launcher (Closed)

Created:
7 years, 3 months ago by Paweł Hajdan Jr.
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

GTTF: Make --help and --gtest_help behave correctly with --brave-new-test-launcher BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223082

Patch Set 1 #

Patch Set 2 : flaky upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M base/test/test_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/test_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/unit_test_launcher.cc View 3 chunks +30 lines, -1 line 0 comments Download
M content/public/test/test_launcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 3 months ago (2013-09-12 23:31:32 UTC) #1
sky
Please reupload, your patch didn't quite make it up.
7 years, 3 months ago (2013-09-12 23:41:08 UTC) #2
Paweł Hajdan Jr.
PTAL
7 years, 3 months ago (2013-09-13 00:13:58 UTC) #3
sky
LGTM
7 years, 3 months ago (2013-09-13 16:28:54 UTC) #4
Paweł Hajdan Jr.
7 years, 3 months ago (2013-09-13 18:22:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r223082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698