Source/bindings/v8/V8PerIsolateData.cpp - Issue 23892012: Pass isolate to v8::Null() function when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8PerIsolateData.cpp

Issue 23892012: Pass isolate to v8::Null() function when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8PerIsolateData.cpp

diff --git a/Source/bindings/v8/V8PerIsolateData.cpp b/Source/bindings/v8/V8PerIsolateData.cpp

index b620a054b1a65f99c1792d4da21746179a40da46..84691b7ef0063ef49a387261841719a90531a909 100644

--- a/Source/bindings/v8/V8PerIsolateData.cpp

+++ b/Source/bindings/v8/V8PerIsolateData.cpp

@@ -74,7 +74,7 @@ void V8PerIsolateData::ensureInitialized(v8::Isolate* isolate)

v8::Persistent<v8::Value>& V8PerIsolateData::ensureLiveRoot()

{

if (m_liveRoot.isEmpty())

- m_liveRoot.set(m_isolate, v8::Null());

+ m_liveRoot.set(m_isolate, v8::Null(m_isolate));

return m_liveRoot.getUnsafe();

}