Source/bindings/v8/ScriptDebugServer.cpp - Issue 23892012: Pass isolate to v8::Null() function when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 23892012: Pass isolate to v8::Null() function when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp

index 05e65393f7a15c8b868c6a49d1cbb92283945438..be1b87d06c71bfc7ac793b6c01b814eb3467d027 100644

--- a/Source/bindings/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/v8/ScriptDebugServer.cpp

@@ -330,7 +330,7 @@ ScriptValue ScriptDebugServer::currentCallFrame()

v8::HandleScope handleScope(m_isolate);

RefPtr<JavaScriptCallFrame> currentCallFrame = wrapCallFrames(m_executionState.newLocal(m_isolate), -1);

if (!currentCallFrame)

- return ScriptValue(v8::Null());

+ return ScriptValue(v8::Null(m_isolate));

v8::Context::Scope contextScope(m_pausedContext);

return ScriptValue(toV8(currentCallFrame.release(), v8::Handle<v8::Object>(), m_pausedContext->GetIsolate()));

}