Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 23892012: Pass isolate to v8::Null() function when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 return PassRefPtr<JavaScriptCallFrame>(); 323 return PassRefPtr<JavaScriptCallFrame>();
324 return JavaScriptCallFrame::create(v8::Debug::GetDebugContext(), v8::Handle< v8::Object>::Cast(currentCallFrameV8)); 324 return JavaScriptCallFrame::create(v8::Debug::GetDebugContext(), v8::Handle< v8::Object>::Cast(currentCallFrameV8));
325 } 325 }
326 326
327 ScriptValue ScriptDebugServer::currentCallFrame() 327 ScriptValue ScriptDebugServer::currentCallFrame()
328 { 328 {
329 ASSERT(isPaused()); 329 ASSERT(isPaused());
330 v8::HandleScope handleScope(m_isolate); 330 v8::HandleScope handleScope(m_isolate);
331 RefPtr<JavaScriptCallFrame> currentCallFrame = wrapCallFrames(m_executionSta te.newLocal(m_isolate), -1); 331 RefPtr<JavaScriptCallFrame> currentCallFrame = wrapCallFrames(m_executionSta te.newLocal(m_isolate), -1);
332 if (!currentCallFrame) 332 if (!currentCallFrame)
333 return ScriptValue(v8::Null()); 333 return ScriptValue(v8::Null(m_isolate));
334 v8::Context::Scope contextScope(m_pausedContext); 334 v8::Context::Scope contextScope(m_pausedContext);
335 return ScriptValue(toV8(currentCallFrame.release(), v8::Handle<v8::Object>() , m_pausedContext->GetIsolate())); 335 return ScriptValue(toV8(currentCallFrame.release(), v8::Handle<v8::Object>() , m_pausedContext->GetIsolate()));
336 } 336 }
337 337
338 void ScriptDebugServer::interruptAndRun(PassOwnPtr<Task> task, v8::Isolate* isol ate) 338 void ScriptDebugServer::interruptAndRun(PassOwnPtr<Task> task, v8::Isolate* isol ate)
339 { 339 {
340 v8::Debug::DebugBreakForCommand(new ClientDataImpl(task), isolate); 340 v8::Debug::DebugBreakForCommand(new ClientDataImpl(task), isolate);
341 } 341 }
342 342
343 void ScriptDebugServer::runPendingTasks() 343 void ScriptDebugServer::runPendingTasks()
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
614 { 614 {
615 return PassOwnPtr<ScriptSourceCode>(); 615 return PassOwnPtr<ScriptSourceCode>();
616 } 616 }
617 617
618 String ScriptDebugServer::preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName) 618 String ScriptDebugServer::preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName)
619 { 619 {
620 return source; 620 return source;
621 } 621 }
622 622
623 } // namespace WebCore 623 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/IDBBindingUtilities.cpp ('k') | Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698