Issue 23892011: Implement crop rect for the dilate and erode (morphology) filters. This provoked some cleanup on th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23892011: Implement crop rect for the dilate and erode (morphology) filters. This provoked some cleanup on th… (Closed)

Created:
7 years, 3 months ago by Stephen White

Modified:
7 years, 3 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Implement crop rect for the dilate and erode (morphology) filters. This provoked some cleanup on the GPU side: apply_morphology() now deals with SkBitmaps, rather than GrTextures. There's still a clear opportunity for more refactoring between the two filters. Note: this adds some test cases to the morphology GM, so it will require a rebaseline. R=bsalomon@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11313

Patch Set 1 #

Patch Set 2 : Don't send an SkScalar to do a int's job. #

Patch Set 3 : Embiggen GM to accommodate new test cases. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -73 lines)			Patch
M	gm/morphology.cpp	View	1 2	3 chunks	+24 lines, -15 lines	0 comments	Download
M	include/effects/SkMorphologyImageFilter.h	View		3 chunks	+9 lines, -5 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	1	12 chunks	+119 lines, -53 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bsalomon

On 2013/09/11 19:49:59, Stephen White wrote: > Brian: PTAL. Thanks! Agree that there's more consolidation ...

7 years, 3 months ago (2013-09-12 13:21:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/23892011/1

7 years, 3 months ago (2013-09-13 14:28:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/23892011/7001

7 years, 3 months ago (2013-09-13 14:43:38 UTC) #5

Stephen White

7 years, 3 months ago (2013-09-17 13:41:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r11313 (presubmit successful).

Expand Messages | Collapse Messages