[heap] Simplify marking of JSFunction and SFI

[heap] Simplify marking of JSFunction and SFI

BUG=chromium:651828
Committed: https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242
Cr-Commit-Position: refs/heads/master@{#39975}

[Michael Lippautz, 2016-10-04 13:57:23]

Description was changed from

==========
[heap] Simplify marking of JSFunctions w/ weak code

BUG=
==========

to

==========
[heap] Simplify marking of JSFunctions and SFI

BUG=
==========

[Michael Lippautz, 2016-10-04 14:00:58]

Description was changed from

==========
[heap] Simplify marking of JSFunctions and SFI

BUG=
==========

to

==========
[heap] Simplify marking of JSFunctions and SFI

BUG=chromium:651828
==========

[Michael Lippautz, 2016-10-04 14:00:58]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-10-04 14:01:17]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[Michael Lippautz, 2016-10-04 14:01:25]

ptal

[commit-bot: I haz the power, 2016-10-04 14:01:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2016-10-04 14:03:06]

Description was changed from

==========
[heap] Simplify marking of JSFunctions and SFI

BUG=chromium:651828
==========

to

==========
[heap] Simplify marking of JSFunction and SFI

BUG=chromium:651828
==========

[commit-bot: I haz the power, 2016-10-04 14:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 14:26:56]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-10-05 07:46:10]

lgtm

[Hannes Payer (out of office), 2016-10-05 07:47:09]

https://codereview.chromium.org/2389183002/diff/20001/src/heap/objects-visiti...
File src/heap/objects-visiting-inl.h (right):

https://codereview.chromium.org/2389183002/diff/20001/src/heap/objects-visiti...
src/heap/objects-visiting-inl.h:633: Map* map, HeapObject* object) {
// Skip visiting kCodeOffset as it is treated weakly here.

[Michael Lippautz, 2016-10-05 07:48:23]

https://codereview.chromium.org/2389183002/diff/20001/src/heap/objects-visiti...
File src/heap/objects-visiting-inl.h (right):

https://codereview.chromium.org/2389183002/diff/20001/src/heap/objects-visiti...
src/heap/objects-visiting-inl.h:633: Map* map, HeapObject* object) {
On 2016/10/05 07:47:09, Hannes Payer wrote:
> // Skip visiting kCodeOffset as it is treated weakly here.

Done.

[Michael Lippautz, 2016-10-05 07:48:32]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 07:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 08:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 08:17:17]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-10-05 08:24:59]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-10-05 08:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2389183002/#ps40001
(title: "Re-add comment")

[commit-bot: I haz the power, 2016-10-05 08:25:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 08:26:48]

Description was changed from

==========
[heap] Simplify marking of JSFunction and SFI

BUG=chromium:651828
==========

to

==========
[heap] Simplify marking of JSFunction and SFI

BUG=chromium:651828
==========

[commit-bot: I haz the power, 2016-10-05 08:26:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 08:27:06]

Description was changed from

==========
[heap] Simplify marking of JSFunction and SFI

BUG=chromium:651828
==========

to

==========
[heap] Simplify marking of JSFunction and SFI

BUG=chromium:651828

Committed: https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242
Cr-Commit-Position: refs/heads/master@{#39975}
==========

[commit-bot: I haz the power, 2016-10-05 08:27:07]

Patchset 3 (id:??) landed as
https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242
Cr-Commit-Position: refs/heads/master@{#39975}

[epertoso, 2016-10-05 10:22:18]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2389963007/ by epertoso@chromium.org.

The reason for reverting is: Broke GCStress..