Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java

Issue 2389153003: [remoting android] Close navigation drawer before opening Help/Feedback. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java b/remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
index f8e7615fb81a948fcad27919a77d1ec0c438422f..b4ab754f14dec03ed736044cf72b12a94173746e 100644
--- a/remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
+++ b/remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
@@ -17,7 +17,6 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chromoting.help.HelpContext;
-import org.chromium.chromoting.help.HelpSingleton;
/**
* Describes the appearance and behavior of the navigation menu. This also implements
@@ -40,33 +39,30 @@ public class NavigationMenuAdapter extends ArrayAdapter<NavigationMenuAdapter.Na
}
}
- public static ListView createNavigationMenu(final Activity activity) {
- ListView navigationMenu = (ListView) activity.getLayoutInflater()
- .inflate(R.layout.navigation_list, null);
+ public static ListView createNavigationMenu(final Chromoting chromoting) {
+ ListView navigationMenu =
+ (ListView) chromoting.getLayoutInflater().inflate(R.layout.navigation_list, null);
NavigationMenuItem feedbackItem = new NavigationMenuItem(
- activity.getResources().getString(R.string.actionbar_send_feedback),
- getIcon(activity, R.drawable.ic_announcement),
- new Runnable() {
+ chromoting.getResources().getString(R.string.actionbar_send_feedback),
+ getIcon(chromoting, R.drawable.ic_announcement), new Runnable() {
@Override
public void run() {
- HelpSingleton.getInstance().launchFeedback(activity);
+ chromoting.launchFeedback();
}
});
NavigationMenuItem helpItem = new NavigationMenuItem(
- activity.getResources().getString(R.string.actionbar_help),
- getIcon(activity, R.drawable.ic_help),
- new Runnable() {
+ chromoting.getResources().getString(R.string.actionbar_help),
+ getIcon(chromoting, R.drawable.ic_help), new Runnable() {
@Override
public void run() {
- HelpSingleton.getInstance().launchHelp(activity,
- HelpContext.HOST_LIST);
+ chromoting.launchHelp(HelpContext.HOST_LIST);
}
});
NavigationMenuItem[] navigationMenuItems = { feedbackItem, helpItem };
- NavigationMenuAdapter adapter = new NavigationMenuAdapter(activity, navigationMenuItems);
+ NavigationMenuAdapter adapter = new NavigationMenuAdapter(chromoting, navigationMenuItems);
navigationMenu.setAdapter(adapter);
navigationMenu.setOnItemClickListener(adapter);
return navigationMenu;

Powered by Google App Engine
This is Rietveld 408576698