Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: mash/app_driver/app_driver.cc

Issue 2389133008: Mash: Replaces "exe:chrome" with "service:content_browser" (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/base/mojo_test_connector.cc ('k') | mash/session/session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mash/app_driver/app_driver.h" 5 #include "mash/app_driver/app_driver.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "mash/public/interfaces/launchable.mojom.h" 11 #include "mash/public/interfaces/launchable.mojom.h"
12 #include "services/shell/public/cpp/connection.h" 12 #include "services/shell/public/cpp/connection.h"
13 #include "services/shell/public/cpp/connector.h" 13 #include "services/shell/public/cpp/connector.h"
14 #include "services/ui/common/event_matcher_util.h" 14 #include "services/ui/common/event_matcher_util.h"
15 15
16 using mash::mojom::LaunchablePtr; 16 using mash::mojom::LaunchablePtr;
17 using mash::mojom::LaunchMode; 17 using mash::mojom::LaunchMode;
18 18
19 namespace mash { 19 namespace mash {
20 namespace app_driver { 20 namespace app_driver {
21 namespace { 21 namespace {
22 22
23 const char kBrowserServiceName[] = "service:content_browser";
24
23 enum class Accelerator : uint32_t { 25 enum class Accelerator : uint32_t {
24 NewChromeWindow, 26 NewChromeWindow,
25 NewChromeTab, 27 NewChromeTab,
26 NewChromeIncognitoWindow, 28 NewChromeIncognitoWindow,
27 ShowTaskManager, 29 ShowTaskManager,
28 }; 30 };
29 31
30 struct AcceleratorSpec { 32 struct AcceleratorSpec {
31 Accelerator id; 33 Accelerator id;
32 ui::mojom::KeyboardCode keyboard_code; 34 ui::mojom::KeyboardCode keyboard_code;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 104
103 void AppDriver::OnAccelerator(uint32_t id, std::unique_ptr<ui::Event> event) { 105 void AppDriver::OnAccelerator(uint32_t id, std::unique_ptr<ui::Event> event) {
104 struct LaunchOptions { 106 struct LaunchOptions {
105 uint32_t option; 107 uint32_t option;
106 const char* app; 108 const char* app;
107 LaunchMode mode; 109 LaunchMode mode;
108 }; 110 };
109 111
110 std::map<Accelerator, LaunchOptions> options{ 112 std::map<Accelerator, LaunchOptions> options{
111 {Accelerator::NewChromeWindow, 113 {Accelerator::NewChromeWindow,
112 {mojom::kWindow, "exe:chrome", LaunchMode::MAKE_NEW}}, 114 {mojom::kWindow, kBrowserServiceName, LaunchMode::MAKE_NEW}},
113 {Accelerator::NewChromeTab, 115 {Accelerator::NewChromeTab,
114 {mojom::kDocument, "exe:chrome", LaunchMode::MAKE_NEW}}, 116 {mojom::kDocument, kBrowserServiceName, LaunchMode::MAKE_NEW}},
115 {Accelerator::NewChromeIncognitoWindow, 117 {Accelerator::NewChromeIncognitoWindow,
116 {mojom::kIncognitoWindow, "exe:chrome", LaunchMode::MAKE_NEW}}, 118 {mojom::kIncognitoWindow, kBrowserServiceName, LaunchMode::MAKE_NEW}},
117 {Accelerator::ShowTaskManager, 119 {Accelerator::ShowTaskManager,
118 {mojom::kWindow, "service:task_viewer", LaunchMode::DEFAULT}}, 120 {mojom::kWindow, "service:task_viewer", LaunchMode::DEFAULT}},
119 }; 121 };
120 122
121 const auto iter = options.find(static_cast<Accelerator>(id)); 123 const auto iter = options.find(static_cast<Accelerator>(id));
122 DCHECK(iter != options.end()); 124 DCHECK(iter != options.end());
123 const LaunchOptions& entry = iter->second; 125 const LaunchOptions& entry = iter->second;
124 LaunchablePtr launchable; 126 LaunchablePtr launchable;
125 connector()->ConnectToInterface(entry.app, &launchable); 127 connector()->ConnectToInterface(entry.app, &launchable);
126 launchable->Launch(entry.option, entry.mode); 128 launchable->Launch(entry.option, entry.mode);
127 } 129 }
128 130
129 void AppDriver::AddAccelerators() { 131 void AppDriver::AddAccelerators() {
130 connector()->ConnectToInterface("service:catalog", &catalog_); 132 connector()->ConnectToInterface("service:catalog", &catalog_);
131 catalog_->GetEntriesProvidingClass( 133 catalog_->GetEntriesProvidingClass(
132 "mus:window_manager", base::Bind(&AppDriver::OnAvailableCatalogEntries, 134 "mus:window_manager", base::Bind(&AppDriver::OnAvailableCatalogEntries,
133 weak_factory_.GetWeakPtr())); 135 weak_factory_.GetWeakPtr()));
134 } 136 }
135 137
136 } // namespace app_driver 138 } // namespace app_driver
137 } // namespace mash 139 } // namespace mash
OLDNEW
« no previous file with comments | « chrome/test/base/mojo_test_connector.cc ('k') | mash/session/session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698