Mash: Replaces "exe:chrome" with "service:content_browser"

Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash, which is
applied on top of Chrome's own overlay.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run task_viewer, etc

Committed: https://crrev.com/3216b12377127f215e8c57a4b835bc6564506119
Cr-Commit-Position: refs/heads/master@{#423803}

[Ken Rockot(use gerrit already), 2016-10-06 18:30:11]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 18:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:35:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:35:07]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-10-06 20:03:53]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-06 20:06:52]

Description was changed from

==========
Replaces all outgoing connections to "exe:chrome" with "exe:content_browser"

Changes the service_manifest GN template to use overlays rather
than the old |base_manifest| stuff. This makes it easy to reuse
the existing overlay metadata with standalone ServiceManager.

Adds a browser manifest overlay specifically for Mash.

TODO: Adds support for overriding exeuctable and manifest
paths in service resolution.

BUG=646077
==========

to

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly.

Also changes the service_manifest GN template to support overlays
rather than the old |base_manifest| stuff. This makes it easy to
reuse the existing overlay metadata with standalone ServiceManager,
as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash.

BUG=646077
==========

[Ken Rockot(use gerrit already), 2016-10-06 20:12:50]

Description was changed from

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly.

Also changes the service_manifest GN template to support overlays
rather than the old |base_manifest| stuff. This makes it easy to
reuse the existing overlay metadata with standalone ServiceManager,
as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash.

BUG=646077
==========

to

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc
==========

[Ken Rockot(use gerrit already), 2016-10-06 20:13:12]

rockot@chromium.org changed reviewers:
+ ben@chromium.org, sky@chromium.org

[Ken Rockot(use gerrit already), 2016-10-06 20:13:13]

sky@ for mashy stuff, ben@ for services stuff

[Ken Rockot(use gerrit already), 2016-10-06 20:19:10]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-10-06 20:19:14]

Patchset #1 (id:1) has been deleted

[Ken Rockot(use gerrit already), 2016-10-06 20:19:19]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-06 20:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-06 20:31:27]

Description was changed from

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc
==========

to

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc
==========

[Ken Rockot(use gerrit already), 2016-10-06 20:32:17]

Description was changed from

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc
==========

to

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash, which is
applied on top of Chrome's own overlay.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc
==========

[Ben Goodger (Google), 2016-10-06 21:46:26]

lgtm but...

https://codereview.chromium.org/2389133008/diff/40001/chrome/app/mash/mash_ru...
File chrome/app/mash/mash_runner.cc (right):

https://codereview.chromium.org/2389133008/diff/40001/chrome/app/mash/mash_ru...
chrome/app/mash/mash_runner.cc:46: const char kChromeMashServiceName[] =
"exe:chrome_mash";
Can we not use exe: prefixes for synthetic names?

[commit-bot: I haz the power, 2016-10-06 22:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 22:22:11]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-10-06 22:35:16]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 22:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-06 22:37:08]

https://codereview.chromium.org/2389133008/diff/40001/chrome/app/mash/mash_ru...
File chrome/app/mash/mash_runner.cc (right):

https://codereview.chromium.org/2389133008/diff/40001/chrome/app/mash/mash_ru...
chrome/app/mash/mash_runner.cc:46: const char kChromeMashServiceName[] =
"exe:chrome_mash";
On 2016/10/06 at 21:46:26, Ben Goodger (Google) wrote:
> Can we not use exe: prefixes for synthetic names?

Done. This means we don't need the ServiceManagerControl interface now, so I've
removed that too.

[Ken Rockot(use gerrit already), 2016-10-06 22:42:37]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-10-06 22:42:47]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-10-06 22:42:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-10-06 22:49:52]

LGTM

[commit-bot: I haz the power, 2016-10-06 23:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:50:25]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-10-07 02:10:41]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-10-07 02:10:56]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-10-07 02:10:58]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-10-07 02:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2389133008/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-07 02:10:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 02:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 02:31:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-10-07 02:34:09]

rockot@chromium.org changed reviewers:
+ dcheng@chromium.org

[Ken Rockot(use gerrit already), 2016-10-07 02:34:10]

dcheng@ for mojom - note that none of the changes here are relevant to
production chrome

[dcheng, 2016-10-07 03:33:03]

mojo lgtm

[Ken Rockot(use gerrit already), 2016-10-07 03:36:15]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-10-07 03:36:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 05:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 05:04:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-10-07 05:24:19]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-10-07 05:24:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 06:02:48]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-10-07 06:04:19]

Description was changed from

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash, which is
applied on top of Chrome's own overlay.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc
==========

to

==========
Mash: Replaces "exe:chrome" with "service:content_browser"

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash, which is
applied on top of Chrome's own overlay.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run
task_viewer, etc

Committed: https://crrev.com/3216b12377127f215e8c57a4b835bc6564506119
Cr-Commit-Position: refs/heads/master@{#423803}
==========

[commit-bot: I haz the power, 2016-10-07 06:04:21]

Patchset 3 (id:??) landed as
https://crrev.com/3216b12377127f215e8c57a4b835bc6564506119
Cr-Commit-Position: refs/heads/master@{#423803}