Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2389133006: Clamp PannerNode rolloffFactor to nominal range (Closed)

Created:
4 years, 2 months ago by Raymond Toy
Modified:
4 years, 2 months ago
Reviewers:
hongchan
CC:
Raymond Toy, blink-reviews, chromium-reviews, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp PannerNode rolloffFactor to nominal range The rolloff factor for the PannerNode is clamped to the nominal range, depending on the distanceModel used for the PannerNode. Feature: https://www.chromestatus.com/feature/4939796648558592 BUG=652712 TEST=panner-rolloff-clamping.html Committed: https://crrev.com/3bf21fc15e3736058a625862c1d3bb4d990bcf6d Cr-Commit-Position: refs/heads/master@{#424306}

Patch Set 1 #

Patch Set 2 : Clean up test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/panner-rolloff-clamping.html View 1 1 chunk +129 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/Distance.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Raymond Toy
PTAL.
4 years, 2 months ago (2016-10-10 18:07:39 UTC) #6
Raymond Toy
PTAL.
4 years, 2 months ago (2016-10-10 20:44:21 UTC) #8
hongchan
lgtm
4 years, 2 months ago (2016-10-10 20:46:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389133006/20001
4 years, 2 months ago (2016-10-10 21:41:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 00:37:24 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:40:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bf21fc15e3736058a625862c1d3bb4d990bcf6d
Cr-Commit-Position: refs/heads/master@{#424306}

Powered by Google App Engine
This is Rietveld 408576698