Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2389133004: [inspector] fix compilation on win and linux (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fix compilation on win and linux BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Committed: https://crrev.com/186e7db8ddf7f31b5ba728cd0bac32a8f2669237 Cr-Commit-Position: refs/heads/master@{#40003}

Patch Set 1 #

Patch Set 2 : fix int conversion issue #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/inspector/string-16.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/inspector-test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/inspector/task-runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
kozy
please take a look
4 years, 2 months ago (2016-10-05 15:49:54 UTC) #10
dgozman
lgtm
4 years, 2 months ago (2016-10-05 17:03:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389133004/40001
4 years, 2 months ago (2016-10-05 17:04:46 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 17:07:34 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 17:07:58 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/186e7db8ddf7f31b5ba728cd0bac32a8f2669237
Cr-Commit-Position: refs/heads/master@{#40003}

Powered by Google App Engine
This is Rietveld 408576698