Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2389133003: GN: use the correct directory for self-invocation. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: use the correct directory for self-invocation. GN writes a Ninja command to re-invoke GN when a build file changes. Previously this hardcoded the build directory. But if the user renames the build directory, Ninja will think the files are out of date but GN will keep regenerating files in another directory. This changes the directory to "." because Ninja will invoke all commands with the build directory as the current one. BUG=639965 Committed: https://crrev.com/eceed2e7c13045dcabfa07e7b7d7b4cd2807a0ec Cr-Commit-Position: refs/heads/master@{#422995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/gn/ninja_build_writer.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
brettw
4 years, 2 months ago (2016-10-04 22:37:45 UTC) #2
scottmg
lgtm if there's tests for self-invocation, add one for this?
4 years, 2 months ago (2016-10-04 23:01:32 UTC) #7
brettw
On 2016/10/04 23:01:32, scottmg wrote: > lgtm > > if there's tests for self-invocation, add ...
4 years, 2 months ago (2016-10-04 23:15:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389133003/1
4 years, 2 months ago (2016-10-04 23:15:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 23:23:09 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:25:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eceed2e7c13045dcabfa07e7b7d7b4cd2807a0ec
Cr-Commit-Position: refs/heads/master@{#422995}

Powered by Google App Engine
This is Rietveld 408576698