Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2389123003: [MD settings] mirror subpage back arrow in rtl (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] mirror subpage back arrow in rtl This CL changes the direction of the back arrow in rtl languages. In ltr we go forward to the right and back to the left. That is reversed in rtl and this CL makes the icon match the language flow. BUG=586579 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c7d64aa5e1360da7f6f5a62ffcc0bdcbafac9af2 Cr-Commit-Position: refs/heads/master@{#422904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dschuyler
4 years, 2 months ago (2016-10-04 18:52:47 UTC) #5
Dan Beam
lgtm
4 years, 2 months ago (2016-10-04 19:04:41 UTC) #6
Dan Beam
added crbug.com/586579
4 years, 2 months ago (2016-10-04 19:05:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389123003/1
4 years, 2 months ago (2016-10-04 20:15:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 20:24:13 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:26:49 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7d64aa5e1360da7f6f5a62ffcc0bdcbafac9af2
Cr-Commit-Position: refs/heads/master@{#422904}

Powered by Google App Engine
This is Rietveld 408576698