Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2389123002: [Mac Fix-It] Use FSPathMakeRef instead of base::mac::FSRefFromPath. (Closed)

Created:
4 years, 2 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 2 months ago
Reviewers:
asanka, erikchen, svaldez
CC:
asanka, chromium-reviews, darin-cc_chromium.org, erikchen, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac Fix-It] Use FSPathMakeRef instead of base::mac::FSRefFromPath. base::mac::FSRefFromPath will be removed as it is relied on deprecated API. The only place where FSPathMakeRef needed is QuarantinePropertiesDeprecated API. So instead of having shared base::mac::FSRefFromPath function which depends on deprecated API it is better to use FSPathMakeRef right in place where it's needed as it will be easier to clean up that code later. BUG=650854 Committed: https://crrev.com/2f7ce1d11fd3b346468569389e8cc97f97453377 Cr-Commit-Position: refs/heads/master@{#423769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/download/quarantine_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Eugene But (OOO till 7-30)
4 years, 2 months ago (2016-10-04 07:21:42 UTC) #2
Eugene But (OOO till 7-30)
Steven?
4 years, 2 months ago (2016-10-06 00:27:11 UTC) #3
Eugene But (OOO till 7-30)
CCing erikchen@ to make sure we not doing the same work
4 years, 2 months ago (2016-10-06 04:00:28 UTC) #4
Eugene But (OOO till 7-30)
Asanka, could you please take a look
4 years, 2 months ago (2016-10-07 00:32:30 UTC) #6
erikchen
lgtm
4 years, 2 months ago (2016-10-07 00:37:34 UTC) #8
asanka
lgtm
4 years, 2 months ago (2016-10-07 00:38:01 UTC) #9
Eugene But (OOO till 7-30)
Thanks!
4 years, 2 months ago (2016-10-07 00:40:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389123002/1
4 years, 2 months ago (2016-10-07 00:40:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 01:05:25 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 01:07:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f7ce1d11fd3b346468569389e8cc97f97453377
Cr-Commit-Position: refs/heads/master@{#423769}

Powered by Google App Engine
This is Rietveld 408576698