Issue 2389113003: [Cronet] Make CFBundleShortVersionString conform x.y.z format on iOS.

Issue 2389113003: [Cronet] Make CFBundleShortVersionString conform x.y.z format on iOS. (Closed)

Created:
4 years, 2 months ago by mef

Modified:
4 years, 2 months ago

Reviewers:
lilyhoughton, kapishnikov

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Cronet] Make CFBundleShortVersionString conform x.y.z format on iOS. BUG=650710 Committed: https://crrev.com/546e56fe757f0e70b16866eb3c30117377112f7c Cr-Commit-Position: refs/heads/master@{#422918}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	components/cronet/ios/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (3 generated)

mef

kapishnikov@: PTAL, this implements advice on crbug. lilyhoughton@: FYI, we need to do the same ...

4 years, 2 months ago (2016-10-04 19:28:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389113003/1

4 years, 2 months ago (2016-10-04 19:32:47 UTC) #5

commit-bot: I haz the power

4 years, 2 months ago (2016-10-04 20:43:59 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/546e56fe757f0e70b16866eb3c30117377112f7c
Cr-Commit-Position: refs/heads/master@{#422918}