Restore correct size for omnibox search icon.

Restore correct size for omnibox search icon.

Even though most OMNIBOX_FOO icons have a 1x version which explicitly
sets a canvas size, this one only has the generic-DSF version so the
icon size must be specified.

BUG=652800
Committed: https://crrev.com/ac15493ce095362317ca851fa6af91bdb729ffe5
Cr-Commit-Position: refs/heads/master@{#423222}

[Evan Stade, 2016-10-04 21:24:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-10-04 21:24:40]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2016-10-04 21:24:40]

In the patch where I removed this, you asked if it was necessary and I said it
wasn't. Turns out I am wrong sometimes.

[commit-bot: I haz the power, 2016-10-04 21:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 22:15:20]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-10-05 00:02:14]

LGTM

https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/selected_keyword_view.cc (right):

https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/selected_keyword_view.cc:34:
SetImage(gfx::CreateVectorIcon(gfx::VectorIconId::OMNIBOX_SEARCH, 16,
Nit: Should this be LocationBarView::kLocationBarIconWidth?

(Seems like that could be renamed "kIconWidth" since it's already scoped by the
classname, but whatever.)

[Evan Stade, 2016-10-05 17:29:20]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 17:29:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-10-05 17:29:43]

https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/selected_keyword_view.cc (right):

https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/selected_keyword_view.cc:34:
SetImage(gfx::CreateVectorIcon(gfx::VectorIconId::OMNIBOX_SEARCH, 16,
On 2016/10/05 00:02:14, Peter Kasting wrote:
> Nit: Should this be LocationBarView::kLocationBarIconWidth?
> 
> (Seems like that could be renamed "kIconWidth" since it's already scoped by
the
> classname, but whatever.)

Done.

[Evan Stade, 2016-10-05 17:33:51]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-10-05 17:33:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2389073004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-10-05 17:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:19:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 18:24:42]

Description was changed from

==========
Restore correct size for omnibox search icon.

Even though most OMNIBOX_FOO icons have a 1x version which explicitly
sets a canvas size, this one only has the generic-DSF version so the
icon size must be specified.

BUG=652800
==========

to

==========
Restore correct size for omnibox search icon.

Even though most OMNIBOX_FOO icons have a 1x version which explicitly
sets a canvas size, this one only has the generic-DSF version so the
icon size must be specified.

BUG=652800

Committed: https://crrev.com/ac15493ce095362317ca851fa6af91bdb729ffe5
Cr-Commit-Position: refs/heads/master@{#423222}
==========

[commit-bot: I haz the power, 2016-10-05 18:24:43]

Patchset 3 (id:??) landed as
https://crrev.com/ac15493ce095362317ca851fa6af91bdb729ffe5
Cr-Commit-Position: refs/heads/master@{#423222}