Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2389073004: Restore correct size for omnibox search icon. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore correct size for omnibox search icon. Even though most OMNIBOX_FOO icons have a 1x version which explicitly sets a canvas size, this one only has the generic-DSF version so the icon size must be specified. BUG=652800 Committed: https://crrev.com/ac15493ce095362317ca851fa6af91bdb729ffe5 Cr-Commit-Position: refs/heads/master@{#423222}

Patch Set 1 #

Total comments: 2

Patch Set 2 : share/rename constant #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/ui/views/location_bar/bubble_icon_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Evan Stade
In the patch where I removed this, you asked if it was necessary and I ...
4 years, 2 months ago (2016-10-04 21:24:40 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/location_bar/selected_keyword_view.cc File chrome/browser/ui/views/location_bar/selected_keyword_view.cc (right): https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/location_bar/selected_keyword_view.cc#newcode34 chrome/browser/ui/views/location_bar/selected_keyword_view.cc:34: SetImage(gfx::CreateVectorIcon(gfx::VectorIconId::OMNIBOX_SEARCH, 16, Nit: Should this be LocationBarView::kLocationBarIconWidth? (Seems ...
4 years, 2 months ago (2016-10-05 00:02:14 UTC) #7
Evan Stade
https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/location_bar/selected_keyword_view.cc File chrome/browser/ui/views/location_bar/selected_keyword_view.cc (right): https://codereview.chromium.org/2389073004/diff/1/chrome/browser/ui/views/location_bar/selected_keyword_view.cc#newcode34 chrome/browser/ui/views/location_bar/selected_keyword_view.cc:34: SetImage(gfx::CreateVectorIcon(gfx::VectorIconId::OMNIBOX_SEARCH, 16, On 2016/10/05 00:02:14, Peter Kasting wrote: > ...
4 years, 2 months ago (2016-10-05 17:29:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389073004/40001
4 years, 2 months ago (2016-10-05 17:34:22 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 18:19:49 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 18:24:43 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac15493ce095362317ca851fa6af91bdb729ffe5
Cr-Commit-Position: refs/heads/master@{#423222}

Powered by Google App Engine
This is Rietveld 408576698