Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2389073003: Fix TaskSchedulerWorkerPoolCheckTlsReuse.CheckDetachedThreads. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TaskSchedulerWorkerPoolCheckTlsReuse.CheckDetachedThreads. BUG= Committed: https://crrev.com/6f0bc5be26eee173701975e99fdd9d7f84f0ec0a Cr-Commit-Position: refs/heads/master@{#422934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/task_scheduler/scheduler_worker_pool_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-04 20:51:20 UTC) #2
dcheng
LGTM but let's put a TODO with a crbug link to track the proper fix.
4 years, 2 months ago (2016-10-04 20:52:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389073003/1
4 years, 2 months ago (2016-10-04 20:53:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 21:29:18 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:33:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f0bc5be26eee173701975e99fdd9d7f84f0ec0a
Cr-Commit-Position: refs/heads/master@{#422934}

Powered by Google App Engine
This is Rietveld 408576698