|
|
Description[ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work
[1] introduced the "fake display" concept, updating OzonePlatformHeadless
and OzonePlatformX11 to use it, but not OzonePlatformWayland.
As a result, "chrome --mash --ozone-platform=wayland" fails to launch.
This CL fixes it by returning a FakeDisplayDelegate instance
in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly
to other off-device capable ozone platforms.
[1] https://codereview.chromium.org/2324163002
BUG=611475
Committed: https://crrev.com/170de2963d3e977eb340fc5e496b3624047018e9
Cr-Commit-Position: refs/heads/master@{#423254}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== [ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work [1] introduced the "fake display" concept, updating OzonePlatformHeadless and OzonePlatformX11 to use it, but not OzonePlatformWayland. As a result, "chrome --mash --ozone-platform=wayland" fails to launch. This CL fixes it by returning a FakeDisplayDelegate instance in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly to other off-device capable ozone platforms. [1] https://codereview.chromium.org/2324163002 BUG=611475 ========== to ========== [ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work [1] introduced the "fake display" concept, updating OzonePlatformHeadless and OzonePlatformX11 to use it, but not OzonePlatformWayland. As a result, "chrome --mash --ozone-platform=wayland" fails to launch. This CL fixes it by returning a FakeDisplayDelegate instance in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly to other off-device capable ozone platforms. [1] https://codereview.chromium.org/2324163002 BUG=611475 ==========
tonikitoo@igalia.com changed reviewers: + kylechar@chromium.org, rjkroege@chromium.org
PTAL. CL updates OzonePlatformWayland::CreateNativeDisplayDelegate similarly to its OzonePlatformX11 and OzonePlatformHeadless counterparts, in order to support "off device" launch.
informal l g t m Also confirming that it allows to launch chrome --mash on Wayland/ChromeOS.
lgtm
The CQ bit was checked by tonikitoo@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
You'll need rjkroege for OWNERS still, I don't have it for top level Ozone.
The CQ bit was unchecked by tonikitoo@igalia.com
On 2016/10/04 13:55:33, kylechar wrote: > You'll need rjkroege for OWNERS still, I don't have it for top level Ozone. Thanks for the review and the heads up, kyle. Just un-cq'ed it.
tonikitoo@igalia.com changed reviewers: + spang@chromium.org
sadrul@chromium.org changed reviewers: + sadrul@chromium.org
stamp lgtm
lgtm
The CQ bit was checked by tonikitoo@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work [1] introduced the "fake display" concept, updating OzonePlatformHeadless and OzonePlatformX11 to use it, but not OzonePlatformWayland. As a result, "chrome --mash --ozone-platform=wayland" fails to launch. This CL fixes it by returning a FakeDisplayDelegate instance in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly to other off-device capable ozone platforms. [1] https://codereview.chromium.org/2324163002 BUG=611475 ========== to ========== [ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work [1] introduced the "fake display" concept, updating OzonePlatformHeadless and OzonePlatformX11 to use it, but not OzonePlatformWayland. As a result, "chrome --mash --ozone-platform=wayland" fails to launch. This CL fixes it by returning a FakeDisplayDelegate instance in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly to other off-device capable ozone platforms. [1] https://codereview.chromium.org/2324163002 BUG=611475 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work [1] introduced the "fake display" concept, updating OzonePlatformHeadless and OzonePlatformX11 to use it, but not OzonePlatformWayland. As a result, "chrome --mash --ozone-platform=wayland" fails to launch. This CL fixes it by returning a FakeDisplayDelegate instance in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly to other off-device capable ozone platforms. [1] https://codereview.chromium.org/2324163002 BUG=611475 ========== to ========== [ozone/wayland] Use FakeDisplayDelegate in order to make "off device" launch work [1] introduced the "fake display" concept, updating OzonePlatformHeadless and OzonePlatformX11 to use it, but not OzonePlatformWayland. As a result, "chrome --mash --ozone-platform=wayland" fails to launch. This CL fixes it by returning a FakeDisplayDelegate instance in OzonePlatformWayland::CreateNativeDisplayDelegate, similarly to other off-device capable ozone platforms. [1] https://codereview.chromium.org/2324163002 BUG=611475 Committed: https://crrev.com/170de2963d3e977eb340fc5e496b3624047018e9 Cr-Commit-Position: refs/heads/master@{#423254} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/170de2963d3e977eb340fc5e496b3624047018e9 Cr-Commit-Position: refs/heads/master@{#423254} |