Chromium Code Reviews

Issue 2389053002: Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
Reviewers:
scheib, ortuno, mbrunson, dcheng, dpapad
CC:
Aaron Boodman, abarth-chromium, arv+watch_chromium.org, chromium-reviews, darin (slow to review), ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (patchset #16 id:280001 of https://codereview.chromium.org/2357383002/ ) Reason for revert: generate_build_files failing on chromium.chrome/Google Chrome Win BUG=652494 C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check -> returned 1 ERROR at //build/split_static_library.gni:27:7: Dependency not allowed. static_library(current_name) { ^----------------------------- The item //chrome/browser/ui:ui_0 can not depend on //device/bluetooth/public/interfaces:experimental_interfaces because it is not in //device/bluetooth/public/interfaces:experimental_interfaces's visibility list: [ //device/bluetooth:mojo //chrome/browser:browser //chrome/browser/ui:ui ] GN gen failed: 1 step returned non-zero exit code: 1 @@@STEP_FAILURE@@@ Original issue's description: > bluetooth: Add device list retrieval for chrome://bluetooth-internals > > Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page. > Adds mojom files for Bluetooth service definition and internals page handler. > Adds basic Bluetooth device retrieval using starter Bluetooth service > implementation for logging on web front end. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > BUG=651282 > > Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9 > Cr-Commit-Position: refs/heads/master@{#422570} TBR=dpapad@chromium.org,dcheng@chromium.org,ortuno@chromium.org,scheib@chromium.org,mbrunson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651282 Committed: https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff Cr-Commit-Position: refs/heads/master@{#422601}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -307 lines)
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -5 lines 0 comments
M chrome/browser/resources/bluetooth_internals/bluetooth_internals.js View 1 chunk +3 lines, -79 lines 0 comments
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments
M chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc View 1 chunk +0 lines, -3 lines 0 comments
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments
D device/bluetooth/adapter.h View 1 chunk +0 lines, -58 lines 0 comments
D device/bluetooth/adapter.cc View 1 chunk +0 lines, -102 lines 0 comments
M device/bluetooth/public/interfaces/BUILD.gn View 1 chunk +1 line, -13 lines 0 comments
D device/bluetooth/public/interfaces/adapter.mojom View 1 chunk +0 lines, -30 lines 0 comments
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
horo
Created Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals
4 years, 2 months ago (2016-10-03 23:32:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389053002/1
4 years, 2 months ago (2016-10-03 23:34:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 23:40:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff Cr-Commit-Position: refs/heads/master@{#422601}
4 years, 2 months ago (2016-10-03 23:43:36 UTC) #7
scheib
4 years, 2 months ago (2016-10-04 01:55:46 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine