Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2389043003: [MD Settings] manage-Profile resets the name to the current name on route change. (Closed)

Created:
4 years, 2 months ago by Moe
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] manage-Profile resets the name to the current name on route change. BUG=630118 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae40e4835137b769558e8020f1441d877f55d909 Cr-Commit-Position: refs/heads/master@{#422882}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/settings/people_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.js View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Moe
Hi, Please review this CL.
4 years, 2 months ago (2016-10-04 14:48:33 UTC) #5
tommycli
LGTM thanks!
4 years, 2 months ago (2016-10-04 19:02:10 UTC) #12
Moe
On 2016/10/04 19:02:10, tommycli wrote: > LGTM thanks! thank you.
4 years, 2 months ago (2016-10-04 19:11:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389043003/20001
4 years, 2 months ago (2016-10-04 19:12:25 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 19:18:44 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:20:38 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae40e4835137b769558e8020f1441d877f55d909
Cr-Commit-Position: refs/heads/master@{#422882}

Powered by Google App Engine
This is Rietveld 408576698