Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2389033003: Build FileDescriptorWatcher for NaCl non-SFI (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build FileDescriptorWatcher for NaCl non-SFI TestLauncherNonSfiMain instantiates a base::TestLauncher which needs to watch a file descriptor. BUG=645114 Committed: https://crrev.com/1696fb9dfdc8095f7cd45239aa64b54603379322 Cr-Commit-Position: refs/heads/master@{#423099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-04 14:18:27 UTC) #7
dcheng
lgtm
4 years, 2 months ago (2016-10-05 07:24:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389033003/1
4 years, 2 months ago (2016-10-05 07:24:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 07:29:49 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 07:32:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1696fb9dfdc8095f7cd45239aa64b54603379322
Cr-Commit-Position: refs/heads/master@{#423099}

Powered by Google App Engine
This is Rietveld 408576698