Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 238903002: We can reuse the variable which is already declared. (Closed)

Created:
6 years, 8 months ago by zino
Modified:
6 years, 8 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@dfin
Visibility:
Public.

Description

We can reuse the variable which is already declared. It is better to reuse the already declared variable than function call. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zino
PTAL Thank you.
6 years, 8 months ago (2014-04-15 09:58:29 UTC) #1
Justin Novosad
On 2014/04/15 09:58:29, zino wrote: > PTAL > > Thank you. lgtm
6 years, 8 months ago (2014-04-15 14:13:31 UTC) #2
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 8 months ago (2014-04-16 01:26:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/238903002/1
6 years, 8 months ago (2014-04-16 01:26:53 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 04:01:51 UTC) #5
Message was sent while issue was closed.
Change committed as 171730

Powered by Google App Engine
This is Rietveld 408576698