Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp

Issue 2389023002: Deferred frame loading stats v2 (Closed)
Patch Set: make display none work. update histograms.xml Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp b/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..e8f0c0686c58becede0a1cfab2934f5e8c65822d
--- /dev/null
+++ b/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
@@ -0,0 +1,174 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "platform/testing/HistogramTester.h"
+#include "platform/testing/UnitTestHelpers.h"
+#include "web/WebViewImpl.h"
+#include "web/tests/sim/SimCompositor.h"
+#include "web/tests/sim/SimDisplayItemList.h"
+#include "web/tests/sim/SimRequest.h"
+#include "web/tests/sim/SimTest.h"
+
+namespace blink {
+
+static const char* kHistogramName =
+ "Navigation.DeferredDocumentLoading.StatesV2";
+
+class DeferredLoadingTest : public SimTest {
+ protected:
+ DeferredLoadingTest() { webView().resize(WebSize(640, 480)); }
+ void compositeFrame() {
+ compositor().beginFrame();
+ testing::runPendingTasks();
+ if (compositor().needsBeginFrame())
+ compositor().beginFrame(); // VisibleNestedInRight doesn't need this.
+ ASSERT_FALSE(compositor().needsBeginFrame());
+ }
+
+ SimRequest createMainResource() {
+ SimRequest mainResource("https://example.com/", "text/html");
+ loadURL("https://example.com/");
+ return mainResource;
+ }
+};
+
+TEST_F(DeferredLoadingTest, Visible) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete("<iframe sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadVisible, 1);
+}
+
+TEST_F(DeferredLoadingTest, Right) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete(
+ "<iframe style='position:absolute; left:105vw;' sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectTotalCount(kHistogramName, 1);
+}
+
+TEST_F(DeferredLoadingTest, Below) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete(
+ "<iframe style='position:absolute; top:105vh;' sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectTotalCount(kHistogramName, 1);
+}
+
+TEST_F(DeferredLoadingTest, Above) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete(
+ "<iframe style='position:absolute; top:-10000px;' sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadAbove, 1);
+}
+
+TEST_F(DeferredLoadingTest, Left) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete(
+ "<iframe style='position:absolute; left:-10000px;' sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadLeft, 1);
+}
+
+// Don't log WouldLoadAbove AND WouldLoadLeft.
+TEST_F(DeferredLoadingTest, AboveAndLeft) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete(
+ "<iframe style='position:absolute; left:-10000px; top:-10000px' sandbox>"
+ "</iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadAbove, 1);
+ histogramTester.expectTotalCount(kHistogramName, 2);
+}
+
+TEST_F(DeferredLoadingTest, ZeroByZero) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete(
+ "<iframe style='height:0px;width:0px;' sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadZeroByZero, 1);
+}
+
+TEST_F(DeferredLoadingTest, DisplayNone) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+
+ mainResource.complete("<iframe style='display:none' sandbox></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadDisplayNone, 1);
+}
+
+TEST_F(DeferredLoadingTest, VisibleNestedInRight) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+ SimRequest frameResource("https://example.com/iframe.html", "text/html");
+
+ mainResource.complete(
+ "<iframe style='position:absolute; left:105vw;' src='iframe.html' "
+ "sandbox></iframe>");
+ frameResource.complete("<iframe></iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 2);
+ histogramTester.expectTotalCount(kHistogramName, 2);
+}
+
+TEST_F(DeferredLoadingTest, LeftNestedInBelow) {
+ HistogramTester histogramTester;
+ SimRequest mainResource = createMainResource();
+ SimRequest frameResource("https://example.com/iframe.html", "text/html");
+
+ mainResource.complete(
+ "<iframe style='position:absolute; top:105vh;' src='iframe.html' "
+ "sandbox></iframe>");
+ frameResource.complete(
+ "<iframe style='position:absolute; left:-10000px;'> </iframe>");
+
+ compositeFrame();
+
+ histogramTester.expectBucketCount(kHistogramName, Created, 2);
+ histogramTester.expectTotalCount(kHistogramName, 2);
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698