Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2389023002: Deferred frame loading stats v2 (Closed)
Patch Set: address comments round 2 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index dbf24300948695646d45183b83c1007d842adeab..732c625ac2ffd2d202272cad072ac5c55005f7f1 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -235,6 +235,29 @@ enum CreateElementFlags {
CreatedByFragmentParser = CreatedByParser | AsynchronousCustomElements,
};
+// Collect data about deferred loading of offscreen cross-origin documents. All
+// cross-origin documents log Created. Only those that would load log a reason.
+// We can then see the % of cross-origin documents that never have to load.
+// See https://crbug.com/635105.
+// Logged to UMA, don't re-arrange entries without creating a new histogram.
+enum WouldLoadReason {
+ Created,
+ // If outer and inner frames aren't in the same process we can't determine
+ // if the inner frame is visible, so just load it.
+ // TODO(dgrogan): Revisit after https://crbug.com/650433 is fixed.
+ WouldLoadOutOfProcess,
+ // The next four indicate frames that are probably used for cross-origin
+ // communication.
+ WouldLoadDisplayNone,
+ WouldLoadZeroByZero,
+ WouldLoadAbove,
+ WouldLoadLeft,
+ // We have to load documents in visible frames.
+ WouldLoadVisible,
+
+ WouldLoadReasonEnd
+};
+
using DocumentClassFlags = unsigned char;
class CORE_EXPORT Document : public ContainerNode,
@@ -1280,7 +1303,8 @@ class CORE_EXPORT Document : public ContainerNode,
bool isInMainFrame() const;
- void onVisibilityMaybeChanged(bool visible);
+ void wouldLoadBecause(WouldLoadReason);
+ WouldLoadReason wouldLoadReason() { return m_wouldLoadReason; }
PropertyRegistry* propertyRegistry();
@@ -1636,7 +1660,7 @@ class CORE_EXPORT Document : public ContainerNode,
Member<SnapCoordinator> m_snapCoordinator;
- bool m_visibilityWasLogged;
+ WouldLoadReason m_wouldLoadReason;
Member<PropertyRegistry> m_propertyRegistry;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698