Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2389013003: Remove a copy from the initialization of OffscreenCanvasFrameDispatcherImpl::m_surfaceId. (Closed)

Created:
4 years, 2 months ago by jbroman
Modified:
4 years, 2 months ago
Reviewers:
xidachen
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a copy from the initialization of OffscreenCanvasFrameDispatcherImpl::m_surfaceId. The constructor parameters can be provided directly, and after doing so it fits on one (80-column) line. Committed: https://crrev.com/fddcf3ce795bf36ddeff71045d8ae87b210247de Cr-Commit-Position: refs/heads/master@{#422774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
Noticed this while doing something unrelated. After Fady's change and the reformat, this wound up ...
4 years, 2 months ago (2016-10-04 04:35:53 UTC) #4
xidachen
cool! lgtm
4 years, 2 months ago (2016-10-04 11:01:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389013003/1
4 years, 2 months ago (2016-10-04 13:41:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 13:46:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 13:48:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fddcf3ce795bf36ddeff71045d8ae87b210247de
Cr-Commit-Position: refs/heads/master@{#422774}

Powered by Google App Engine
This is Rietveld 408576698