Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2389013002: cros: Backspace button no longer changes sizes. (Closed)

Created:
4 years, 2 months ago by sammiequon
Modified:
4 years, 2 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Backspace button changes sizes. Fix bug where disabled backspace button would be a bit too small. Also fix bug where chrome user pods were not transitioning. BUG=651954, 633542 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0c6fc7e0f53ace3e0e4be7959dfc1942917c117b Cr-Commit-Position: refs/heads/master@{#422611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sammiequon
On 2016/10/03 22:11:05, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:jdufault@chromium.org, mailto:xiyuan@chromium.org jdufault@, xiyuan@ ...
4 years, 2 months ago (2016-10-03 22:11:40 UTC) #4
xiyuan
lgtm
4 years, 2 months ago (2016-10-03 22:16:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389013002/1
4 years, 2 months ago (2016-10-03 22:28:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:06:18 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:09:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c6fc7e0f53ace3e0e4be7959dfc1942917c117b
Cr-Commit-Position: refs/heads/master@{#422611}

Powered by Google App Engine
This is Rietveld 408576698