tests/lib/mirrors/generics_test.dart - Issue 23890036: Change return type of get typeVariables and typeArguments in ClassMirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/mirrors/generics_test.dart

Issue 23890036: Change return type of get typeVariables and typeArguments in ClassMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/mirrors/mirrors.dart ('K') | « tests/lib/mirrors/class_mirror_type_variables_test.dart ('k') | tests/lib/mirrors/mirrors_test.dart » ('j') | tests/lib/mirrors/typevariable_mirror_metadata_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/lib/mirrors/generics_test.dart

diff --git a/tests/lib/mirrors/generics_test.dart b/tests/lib/mirrors/generics_test.dart

index e5e2c2ff179481d714f86b626c9d2d44c6f16915..a3a7ab8714161718f43938060bf8204048e2e06c 100644

--- a/tests/lib/mirrors/generics_test.dart

+++ b/tests/lib/mirrors/generics_test.dart

@@ -19,16 +19,12 @@ class H<A,B,C> {}

typeParameters(mirror, parameterNames) {

Expect.listEquals(parameterNames.map((n) => new Symbol(n)).toList(),

- mirror.typeVariables.keys.toList());

+ mirror.typeVariables.map((v) => v.simpleName).toList());

}

typeArguments(mirror, argumentMirrors) {

Expect.listEquals(argumentMirrors,

- mirror.typeArguments.values.toList());

- if (!mirror.isOriginalDeclaration) {

- Expect.listEquals(mirror.typeVariables.keys.toList(),

- mirror.typeArguments.keys.toList());

- }

+ mirror.typeArguments);

}

main() {