Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 23890033: Some fixes for SortBench (Closed)

Created:
7 years, 3 months ago by mtklein
Modified:
7 years, 3 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

1) Don't allocate 100,000 ints when we only need 1,000. 2) Don't sort past the end of the array when using SkTQSort. 3) Don't allocate any arrays until we need them (in onDraw). Also, propagate the constant N everywhere through the bench. BUG= R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=11329

Patch Set 1 #

Patch Set 2 : hack #

Patch Set 3 : fix test #

Total comments: 6

Patch Set 4 : bungeman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M bench/SortBench.cpp View 1 2 3 6 chunks +40 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
7 years, 3 months ago (2013-09-17 18:56:41 UTC) #1
bungeman-skia
https://codereview.chromium.org/23890033/diff/6001/bench/SortBench.cpp File bench/SortBench.cpp (right): https://codereview.chromium.org/23890033/diff/6001/bench/SortBench.cpp#newcode15 bench/SortBench.cpp:15: static void rand_proc(int array[]) { If we're not passing ...
7 years, 3 months ago (2013-09-17 19:16:10 UTC) #2
mtklein
https://codereview.chromium.org/23890033/diff/6001/bench/SortBench.cpp File bench/SortBench.cpp (right): https://codereview.chromium.org/23890033/diff/6001/bench/SortBench.cpp#newcode15 bench/SortBench.cpp:15: static void rand_proc(int array[]) { On 2013/09/17 19:16:10, bungeman1 ...
7 years, 3 months ago (2013-09-17 19:26:03 UTC) #3
bungeman-skia
lgtm
7 years, 3 months ago (2013-09-17 19:35:21 UTC) #4
mtklein
7 years, 3 months ago (2013-09-17 19:37:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r11329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698