Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3260)

Unified Diff: cc/resources/video_resource_updater.cc

Issue 2389003002: Call libyuv for short->half-float conversion (Closed)
Patch Set: verbose arguments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/video_resource_updater.cc
diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc
index e56c3853fbe383d95bcf46d4f5d6f6615e02e738..9b35d3b4716814cf1f5521bed19da82d2f7f2681 100644
--- a/cc/resources/video_resource_updater.cc
+++ b/cc/resources/video_resource_updater.cc
@@ -22,6 +22,7 @@
#include "media/renderers/skcanvas_video_renderer.h"
#include "third_party/khronos/GLES2/gl2.h"
#include "third_party/khronos/GLES2/gl2ext.h"
+#include "third_party/libyuv/include/libyuv.h"
#include "third_party/skia/include/core/SkCanvas.h"
#include "ui/gfx/geometry/size_conversions.h"
@@ -298,19 +299,14 @@ void VideoResourceUpdater::MakeHalfFloats(const uint16_t* src,
int bits_per_channel,
size_t num,
uint16_t* dst) {
- // TODO(hubbe): Make AVX and neon versions of this code.
-
- // This magic constant is 2^-112. Multiplying by this
- // is the same as subtracting 112 from the exponent, which
- // is the difference in exponent bias between 32-bit and
- // 16-bit floats. Once we've done this subtraction, we can
- // simply extract the low bits of the exponent and the high
- // bits of the mantissa from our float and we're done.
- float mult = 1.9259299444e-34f / ((1 << bits_per_channel) - 1);
- for (size_t i = 0; i < num; i++) {
- float value = src[i] * mult;
- dst[i] = (*(uint32_t*)&value) >> 13;
- }
+ // Source and dest stride can be zero since we're only copying
+ // one row at a time.
+ int stride = 0;
+ // Maximum value used in |src|.
+ int max_value = (1 << bits_per_channel) - 1;
+ // Copy one row.
danakj 2016/10/03 23:47:44 this comment's redundant i think, the var says the
hubbe 2016/10/03 23:56:35 Done.
+ int rows = 1;
+ libyuv::HalfFloatPlane(src, stride, dst, stride, 1.0f / max_value, num, rows);
}
VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(
« no previous file with comments | « cc/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698