Rollback trunk to 3.21.15.

src/array.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 381 matching lines @@
   if (!IS_UNDEFINED(result)) return result;
 
   return Join(this, length, separator, ConvertToString);
 }
 
 
 function ObservedArrayPop(n) {
   n--;
   var value = this[n];
 
+  EnqueueSpliceRecord(this, n, [value], 0);
+
   try {
     BeginPerformSplice(this);
     delete this[n];
     this.length = n;
   } finally {
     EndPerformSplice(this);
-    EnqueueSpliceRecord(this, n, [value], 0);
   }
 
   return value;
 }
 
 // Removes the last element from the array and returns it. See
 // ECMA-262, section 15.4.4.6.
 function ArrayPop() {
   if (IS_NULL_OR_UNDEFINED(this) && !IS_UNDETECTABLE(this)) {
     throw MakeTypeError("called_on_null_or_undefined",
@@ skipping 14 matching lines @@
   delete this[n];
   this.length = n;
   return value;
 }
 
 
 function ObservedArrayPush() {
   var n = TO_UINT32(this.length);
   var m = %_ArgumentsLength();
 
+  EnqueueSpliceRecord(this, n, [], m);
+
   try {
     BeginPerformSplice(this);
     for (var i = 0; i < m; i++) {
       this[i+n] = %_Arguments(i);
     }
     this.length = n + m;
   } finally {
     EndPerformSplice(this);
-    EnqueueSpliceRecord(this, n, [], m);
   }
 
   return this.length;
 }
 
 // Appends the arguments to the end of the array and returns the new
 // length of the array. See ECMA-262, section 15.4.4.7.
 function ArrayPush() {
   if (IS_NULL_OR_UNDEFINED(this) && !IS_UNDETECTABLE(this)) {
     throw MakeTypeError("called_on_null_or_undefined",
@@ skipping 110 matching lines @@
       }
     }
   }
   return this;
 }
 
 
 function ObservedArrayShift(len) {
   var first = this[0];
 
+  EnqueueSpliceRecord(this, 0, [first], 0);
+
   try {
     BeginPerformSplice(this);
     SimpleMove(this, 0, 1, len, 0);
     this.length = len - 1;
   } finally {
     EndPerformSplice(this);
-    EnqueueSpliceRecord(this, 0, [first], 0);
   }
 
   return first;
 }
 
 function ArrayShift() {
   if (IS_NULL_OR_UNDEFINED(this) && !IS_UNDETECTABLE(this)) {
     throw MakeTypeError("called_on_null_or_undefined",
                         ["Array.prototype.shift"]);
   }
@@ skipping 18 matching lines @@
 
   this.length = len - 1;
 
   return first;
 }
 
 function ObservedArrayUnshift() {
   var len = TO_UINT32(this.length);
   var num_arguments = %_ArgumentsLength();
 
+  EnqueueSpliceRecord(this, 0, [], num_arguments);
+
   try {
     BeginPerformSplice(this);
     SimpleMove(this, 0, 0, len, num_arguments);
     for (var i = 0; i < num_arguments; i++) {
       this[i] = %_Arguments(i);
     }
     this.length = len + num_arguments;
   } finally {
     EndPerformSplice(this);
-    EnqueueSpliceRecord(this, 0, [], num_arguments);
   }
 
   return len + num_arguments;
 }
 
 function ArrayUnshift(arg1) {  // length == 1
   if (IS_NULL_OR_UNDEFINED(this) && !IS_UNDETECTABLE(this)) {
     throw MakeTypeError("called_on_null_or_undefined",
                         ["Array.prototype.unshift"]);
   }
@@ skipping 1005 matching lines @@
   ));
 
   SetUpLockedPrototype(InternalPackedArray, $Array(), $Array(
     "join", getFunction("join", ArrayJoin),
     "pop", getFunction("pop", ArrayPop),
     "push", getFunction("push", ArrayPush)
   ));
 }
 
 SetUpArray();