Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Side by Side Diff: src/api.cc

Issue 23890027: Add flags to force or prevent setting of isolate.is_memory_constrained. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix dumb typo in ASSERT and add tests to test-flags.cc Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 ASSERT(!isolate->IsInitialized()); 617 ASSERT(!isolate->IsInitialized());
618 bool result = isolate->heap()->ConfigureHeap(young_space_size / 2, 618 bool result = isolate->heap()->ConfigureHeap(young_space_size / 2,
619 old_gen_size, 619 old_gen_size,
620 max_executable_size); 620 max_executable_size);
621 if (!result) return false; 621 if (!result) return false;
622 } 622 }
623 if (constraints->stack_limit() != NULL) { 623 if (constraints->stack_limit() != NULL) {
624 uintptr_t limit = reinterpret_cast<uintptr_t>(constraints->stack_limit()); 624 uintptr_t limit = reinterpret_cast<uintptr_t>(constraints->stack_limit());
625 isolate->stack_guard()->SetStackLimit(limit); 625 isolate->stack_guard()->SetStackLimit(limit);
626 } 626 }
627 if (constraints->is_memory_constrained().has_value) { 627 if (constraints->is_memory_constrained().has_value &&
628 !i::FLAG_force_memory_constrained.has_value) {
628 isolate->set_is_memory_constrained( 629 isolate->set_is_memory_constrained(
629 constraints->is_memory_constrained().value); 630 constraints->is_memory_constrained().value);
630 } 631 }
631 return true; 632 return true;
632 } 633 }
633 634
634 635
635 i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) { 636 i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) {
636 if (IsDeadCheck(isolate, "V8::Persistent::New")) return NULL; 637 if (IsDeadCheck(isolate, "V8::Persistent::New")) return NULL;
637 LOG_API(isolate, "Persistent::New"); 638 LOG_API(isolate, "Persistent::New");
(...skipping 7226 matching lines...) Expand 10 before | Expand all | Expand 10 after
7864 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 7865 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
7865 Address callback_address = 7866 Address callback_address =
7866 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 7867 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
7867 VMState<EXTERNAL> state(isolate); 7868 VMState<EXTERNAL> state(isolate);
7868 ExternalCallbackScope call_scope(isolate, callback_address); 7869 ExternalCallbackScope call_scope(isolate, callback_address);
7869 callback(info); 7870 callback(info);
7870 } 7871 }
7871 7872
7872 7873
7873 } } // namespace v8::internal 7874 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698