Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23890006: Disable AwSettingsTest.testUseWideViewportLayoutWidth test. (Closed)

Created:
7 years, 3 months ago by aboxhall
Modified:
7 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Disable AwSettingsTest.testUseWideViewportLayoutWidth test. BUG=285995 R=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221528

Patch Set 1 #

Patch Set 2 : Fix comment/annotation #

Total comments: 2

Patch Set 3 : Explicitly specify Blink revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aboxhall
7 years, 3 months ago (2013-09-05 21:45:34 UTC) #1
aboxhall
Fixed incorrect annotation/commenting.
7 years, 3 months ago (2013-09-05 21:50:13 UTC) #2
mnaganov (inactive)
https://codereview.chromium.org/23890006/diff/4001/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java (right): https://codereview.chromium.org/23890006/diff/4001/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java#newcode2246 android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:2246: * Failing after r157293, see crbug.com/285995 Please specify that ...
7 years, 3 months ago (2013-09-05 21:50:20 UTC) #3
aboxhall
https://codereview.chromium.org/23890006/diff/4001/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java (right): https://codereview.chromium.org/23890006/diff/4001/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java#newcode2246 android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:2246: * Failing after r157293, see crbug.com/285995 On 2013/09/05 21:50:20, ...
7 years, 3 months ago (2013-09-05 21:54:38 UTC) #4
mnaganov (inactive)
lgtm
7 years, 3 months ago (2013-09-05 21:54:58 UTC) #5
aboxhall
7 years, 3 months ago (2013-09-05 22:03:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r221528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698