Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2388993003:
Fixed the crash in Vulkan Shaders in Unit Testing. (Closed)
DescriptionFixed the crash in Vulkan Shaders in Unit Testing.
The unit testing of vulkan shader module crashed since the codeSize
was passed wrongly as length/4 instead of original length in vkCreateShaderModule.
As per specification, codeSize is the size, in bytes, of the code pointed to by pCode.
So it cannot be less than the length returned by std::string::length().
Changed the codeSize from length/4 to length.
BUG = 582558, 582564
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/58e3e35913b944b369bf1e2c1f96396515ed59ca
Cr-Commit-Position: refs/heads/master@{#424387}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Fixed the crash in Vulkan Shaders in Unit Testing. The Unit testing of vulkan shader module crashed since the codesize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. Changed the codesize from length/4 to length. BUG = 582558 582564 ========== to ========== Fixed the crash in Vulkan Shaders in Unit Testing. The Unit testing of vulkan shader module crashed since the codesize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. Changed the codesize from length/4 to length. BUG = 582558 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fixed the crash in Vulkan Shaders in Unit Testing. The Unit testing of vulkan shader module crashed since the codesize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. Changed the codesize from length/4 to length. BUG = 582558 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fixed the crash in Vulkan Shaders in Unit Testing. The Unit testing of vulkan shader module crashed since the codesize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. Changed the codesize from length/4 to length. BUG = 582558 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
soorya.r@samsung.com changed reviewers: + a.suchit@chromium.org
Please review
Please give some more details about the vulkan API : As per specification " codeSize is the size, in bytes, of the code pointed to by pCode. So pcode can not be less than length return by std::string::length().
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Description was changed from ========== Fixed the crash in Vulkan Shaders in Unit Testing. The Unit testing of vulkan shader module crashed since the codesize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. Changed the codesize from length/4 to length. BUG = 582558 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fixed the crash in Vulkan Shaders in Unit Testing. The unit testing of vulkan shader module crashed since the codeSize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. As per specification, codeSize is the size, in bytes, of the code pointed to by pCode. So it cannot be less than the length returned by std::string::length(). Changed the codeSize from length/4 to length. BUG = 582558, 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
a.suchit@chromium.org changed reviewers: + piman@chromium.org
Peer review looks good to me
soorya.r@samsung.com changed reviewers: + dyen@chromium.org
soorya.r@samsung.com changed reviewers: + aelias@chromium.org
lgtm
The CQ bit was checked by a.suchit@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fixed the crash in Vulkan Shaders in Unit Testing. The unit testing of vulkan shader module crashed since the codeSize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. As per specification, codeSize is the size, in bytes, of the code pointed to by pCode. So it cannot be less than the length returned by std::string::length(). Changed the codeSize from length/4 to length. BUG = 582558, 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fixed the crash in Vulkan Shaders in Unit Testing. The unit testing of vulkan shader module crashed since the codeSize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. As per specification, codeSize is the size, in bytes, of the code pointed to by pCode. So it cannot be less than the length returned by std::string::length(). Changed the codeSize from length/4 to length. BUG = 582558, 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fixed the crash in Vulkan Shaders in Unit Testing. The unit testing of vulkan shader module crashed since the codeSize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. As per specification, codeSize is the size, in bytes, of the code pointed to by pCode. So it cannot be less than the length returned by std::string::length(). Changed the codeSize from length/4 to length. BUG = 582558, 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fixed the crash in Vulkan Shaders in Unit Testing. The unit testing of vulkan shader module crashed since the codeSize was passed wrongly as length/4 instead of original length in vkCreateShaderModule. As per specification, codeSize is the size, in bytes, of the code pointed to by pCode. So it cannot be less than the length returned by std::string::length(). Changed the codeSize from length/4 to length. BUG = 582558, 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/58e3e35913b944b369bf1e2c1f96396515ed59ca Cr-Commit-Position: refs/heads/master@{#424387} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/58e3e35913b944b369bf1e2c1f96396515ed59ca Cr-Commit-Position: refs/heads/master@{#424387} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
