Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2388983002: reflow comments in public/modules/{notifications,push_messaging} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, dglazkov+blink, blink-reviews, harkness+watch_chromium.org, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in public/modules/{notifications,push_messaging} BUG=563793 Committed: https://crrev.com/ffd9957533d6ee9facb544a2968f3a7b6a2186ae Cr-Commit-Position: refs/heads/master@{#422598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h View 1 chunk +10 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/modules/push_messaging/WebPushSubscription.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 2 months ago (2016-10-03 21:38:28 UTC) #2
dcheng
lgtm
4 years, 2 months ago (2016-10-03 22:04:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388983002/1
4 years, 2 months ago (2016-10-03 22:06:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 23:37:42 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:40:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffd9957533d6ee9facb544a2968f3a7b6a2186ae
Cr-Commit-Position: refs/heads/master@{#422598}

Powered by Google App Engine
This is Rietveld 408576698