Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2388943002: cc: Delete unused AnimationCurve::AffectsScale and related code (Closed)

Created:
4 years, 2 months ago by ajuma
Modified:
4 years, 2 months ago
Reviewers:
loyso (OOO), jaydasika
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Delete unused AnimationCurve::AffectsScale and related code This deletes AnimationCurve::AffectsScale, TransformOperations::AffectsScale, and ElementAnimations::HasAnimationThatAffectsScale. These are all unused. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/eb550da1827ac1abc44bb0c2b4b717fd89724f20 Cr-Commit-Position: refs/heads/master@{#422552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -216 lines) Patch
M cc/animation/animation_curve.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/animation/animation_player.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/animation/animation_player.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M cc/animation/element_animations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M cc/animation/keyframed_animation_curve.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/animation/keyframed_animation_curve.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M cc/animation/transform_operations.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/animation/transform_operations.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M cc/animation/transform_operations_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/animation_test_common.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/transform_animation_curve_adapter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/compositor/transform_animation_curve_adapter.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ajuma
4 years, 2 months ago (2016-10-03 20:30:09 UTC) #6
jaydasika
lgtm
4 years, 2 months ago (2016-10-03 20:57:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388943002/1
4 years, 2 months ago (2016-10-03 21:08:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:04:40 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:06:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb550da1827ac1abc44bb0c2b4b717fd89724f20
Cr-Commit-Position: refs/heads/master@{#422552}

Powered by Google App Engine
This is Rietveld 408576698