Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2388933002: [DevTools] Update inspector/service-workers tests. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Update inspector/service-workers tests. Added service-worker-pause.html. Updated expectations on some tests. BUG=648775, 480769, 564403 Committed: https://crrev.com/1921bdaf02e1a61af60f27a7529f3b97a0018ad0 Cr-Commit-Position: refs/heads/master@{#422511}

Patch Set 1 #

Patch Set 2 : no crash #

Messages

Total messages: 14 (9 generated)
dgozman
Take a look please.
4 years, 2 months ago (2016-10-03 19:27:30 UTC) #3
kozy
lgtm
4 years, 2 months ago (2016-10-03 19:42:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388933002/20001
4 years, 2 months ago (2016-10-03 20:16:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 20:24:12 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:26:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1921bdaf02e1a61af60f27a7529f3b97a0018ad0
Cr-Commit-Position: refs/heads/master@{#422511}

Powered by Google App Engine
This is Rietveld 408576698