Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2388913002: Use FileDescriptorWatcher in BrlapiConnectionImpl. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in BrlapiConnectionImpl. This allows BrlapiConnectionImpl to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/ddf00b80457978be7e72730b1f78d4c411572f6e Cr-Commit-Position: refs/heads/master@{#423602}

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc View 1 5 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-03 19:52:36 UTC) #10
David Tseng
lgtm
4 years, 2 months ago (2016-10-06 18:06:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388913002/20001
4 years, 2 months ago (2016-10-06 18:16:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 18:42:40 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:44:42 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddf00b80457978be7e72730b1f78d4c411572f6e
Cr-Commit-Position: refs/heads/master@{#423602}

Powered by Google App Engine
This is Rietveld 408576698