Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: scripts/slave/recipes/gpu.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: once more... Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/gpu.py
diff --git a/scripts/slave/recipes/gpu.py b/scripts/slave/recipes/gpu.py
index f321296c9dfd9fb92657335f2b4db55ef196018f..8fdfdd6de4f26612b4d96eb0eec3f4b8b8506106 100644
--- a/scripts/slave/recipes/gpu.py
+++ b/scripts/slave/recipes/gpu.py
@@ -12,6 +12,7 @@ DEPS = [
'chromium',
'gclient',
'path',
+ 'platform',
'properties',
'rietveld',
]
@@ -110,23 +111,15 @@ def GenTests(api):
for plat in ['win', 'mac', 'linux']:
# Normal builder configuration
base_name = '%s_%s' % (plat, build_config.lower())
- yield base_name, {
- 'properties': api.properties_scheduled(
- build_config=build_config),
- 'mock': {
- 'platform': {
- 'name': plat
- }
- }
- }
+ yield (
+ api.test(base_name) +
+ api.properties.scheduled(build_config=build_config) +
+ api.platform.name(plat)
+ )
# Try server configuration
- yield '%s_tryserver' % base_name, {
- 'properties': api.properties_tryserver(
- build_config=build_config),
- 'mock': {
- 'platform': {
- 'name': plat
- }
- }
- }
+ yield (
+ api.test('%s_tryserver' % base_name) +
+ api.properties.tryserver(build_config=build_config) +
+ api.platform.name(plat)
+ )

Powered by Google App Engine
This is Rietveld 408576698