Refactor the way that TestApi works so that it is actually useful.

scripts/slave/recipes/v8.py

Index: scripts/slave/recipes/v8.py
diff --git a/scripts/slave/recipes/v8.py b/scripts/slave/recipes/v8.py
index d2b35e90735ffb7c4a1316ed35c489bf4f19941e..67a6bebdc5129335db10a11a3038d3d9193f303c 100644
--- a/scripts/slave/recipes/v8.py
+++ b/scripts/slave/recipes/v8.py
@@ -4,6 +4,7 @@
 
 DEPS = [
   'v8',
+  'platform',
 ]
 
 def GenSteps(api):
@@ -16,36 +17,25 @@ def GenSteps(api):
   # Tests.
   # TODO(machenbach): Implement the tests.
 
-def GenTests(_api):
+def GenTests(api):
   for bits in [32, 64]:
     for build_config in ['Release', 'Debug']:
-      yield '%s%s' % (build_config, bits), {
-        'properties': {
-          'build_config': build_config,
-          'bits': bits,
-        },
-      }
+      yield (
+        api.Test('%s%s' % (build_config, bits)) +
+        api.Properties(build_config=build_config, bits=bits)
+      )
 
   for build_config in ['Release', 'Debug']:
-    yield 'arm_%s' % (build_config), {
-      'properties': {
-        'build_config': build_config,
-        'target_arch': 'arm',
-      },
-  }
-
-  yield 'default_platform', {
-    'mock': {
-      'platform': {
-        'name': 'linux',
-        'bits': 64,
-      }
-    },
-  }
-
-  yield 'clobber', {
-    'properties': {
-      'clobber': '',
-    },
-  }
+    yield (
+      api.Test('arm_%s' % build_config) +
+      api.Properties(build_config=build_config, target_arch='arm')
+    )
 
+  yield (
+    api.Test('mips_target') +
+    api.Properties(build_config=build_config, target_arch='mips')

[agable, 2013/09/21 02:05:31]

The fact that these are capitalized in GenTests but never in GenSteps makes me
sad. Even though the reason is clear -- in Steps we're using the api to access
its methods, and in Tests we're using it to construct a fake -- it looks and
feels weird. The whole point of this was to 'unify' APIs across steps and tests.

[agable, 2013/09/21 02:05:31]

build_config doesn't have a well-defined value here. This yield is outside all
loops.

[iannucci, 2013/09/21 03:12:34]

Yeah, Done.

[iannucci, 2013/09/21 03:12:34]

Oops. Additional unit test fail. Done

+  )
+
+  yield api.Test('default_platform') + api.platform('linux', 64)
+
+  yield api.Test('clobber') + api.Properties(clobber='')