scripts/slave/recipe_modules/python/api.py - Issue 23889036: Refactor the way that TestApi works so that it is actually useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/python/api.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/path/test_api.py ('K') | « scripts/slave/recipe_modules/python/__init__.py ('k') | scripts/slave/recipe_modules/raw/__init__.py » ('j') | scripts/slave/recipe_modules/raw/__init__.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/python/api.py

diff --git a/scripts/slave/recipe_modules/python/api.py b/scripts/slave/recipe_modules/python/api.py

index 3e59bc987d91fc7bae0949605d695230d1524ed5..a59901df346788dd9a6d7a380ca84f267d2e70f3 100644

--- a/scripts/slave/recipe_modules/python/api.py

+++ b/scripts/slave/recipe_modules/python/api.py

@@ -3,6 +3,7 @@

# found in the LICENSE file.

from slave import recipe_api

+from slave import recipe_util

import textwrap

@@ -23,9 +24,9 @@ class PythonApi(recipe_api.RecipeApi):

program = textwrap.dedent(program)

compile(program, '<string>', 'exec', dont_inherit=1)

- @recipe_api.wrap_followup(kwargs)

+ @recipe_util.wrap_followup(kwargs)

def inline_followup(step_result):

step_result.presentation.logs['python.inline'] = program.splitlines()

- return self(name, recipe_api.InputDataPlaceholder(program, '.py'),

+ return self(name, self.m.raw.input(program, '.py', self.name),

followup_fn=inline_followup, **kwargs)