Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: scripts/slave/recipes/v8.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Yeeeeaaaahhhhhh! Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.py
diff --git a/scripts/slave/recipes/v8.py b/scripts/slave/recipes/v8.py
index d2b35e90735ffb7c4a1316ed35c489bf4f19941e..67a6bebdc5129335db10a11a3038d3d9193f303c 100644
--- a/scripts/slave/recipes/v8.py
+++ b/scripts/slave/recipes/v8.py
@@ -4,6 +4,7 @@
DEPS = [
'v8',
+ 'platform',
]
def GenSteps(api):
@@ -16,36 +17,25 @@ def GenSteps(api):
# Tests.
# TODO(machenbach): Implement the tests.
-def GenTests(_api):
+def GenTests(api):
for bits in [32, 64]:
for build_config in ['Release', 'Debug']:
- yield '%s%s' % (build_config, bits), {
- 'properties': {
- 'build_config': build_config,
- 'bits': bits,
- },
- }
+ yield (
+ api.Test('%s%s' % (build_config, bits)) +
+ api.Properties(build_config=build_config, bits=bits)
+ )
for build_config in ['Release', 'Debug']:
- yield 'arm_%s' % (build_config), {
- 'properties': {
- 'build_config': build_config,
- 'target_arch': 'arm',
- },
- }
-
- yield 'default_platform', {
- 'mock': {
- 'platform': {
- 'name': 'linux',
- 'bits': 64,
- }
- },
- }
-
- yield 'clobber', {
- 'properties': {
- 'clobber': '',
- },
- }
+ yield (
+ api.Test('arm_%s' % build_config) +
+ api.Properties(build_config=build_config, target_arch='arm')
+ )
+ yield (
+ api.Test('mips_target') +
+ api.Properties(build_config=build_config, target_arch='mips')
+ )
+
+ yield api.Test('default_platform') + api.platform('linux', 64)
+
+ yield api.Test('clobber') + api.Properties(clobber='')

Powered by Google App Engine
This is Rietveld 408576698