Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: scripts/slave/recipes/polymer.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Yeeeeaaaahhhhhh! Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/polymer.py
diff --git a/scripts/slave/recipes/polymer.py b/scripts/slave/recipes/polymer.py
index 06bc82bec06ba92b1cc1ae1a5f0e14882b6bffee..3df8d1ee4b8860a5a9893147ace8d96333d4a475 100644
--- a/scripts/slave/recipes/polymer.py
+++ b/scripts/slave/recipes/polymer.py
@@ -97,20 +97,21 @@ def GenSteps(api):
def GenTests(api):
# Test paths and commands on each platform.
for plat in ('mac', 'linux', 'win'):
- yield 'polymer-%s' % plat, {
- 'properties': api.properties_scheduled(
- repository='https://github.com/Polymer/polymer',
- buildername='polymer %s' % plat),
- 'mock': {
- 'platform': {
- 'name': plat
- }
- },
- }
+ yield (
+ api.Test('polymer-%s' % plat) +
+ api.properties.scheduled(
+ repository='https://github.com/Polymer/polymer',
+ buildername='polymer %s' % plat,
+ ) +
+ api.platform.name(plat)
+ )
+
# Make sure the steps are right for deps-triggered jobs.
- yield 'polymer-from-platform', {
- 'properties': api.properties_scheduled(
- repository='https://github.com/Polymer/platform',
- buildername='polymer linux',
- scheduler='polymer-platform')
- }
+ yield (
+ api.Test('polymer-from-platform') +
+ api.properties.scheduled(
+ repository='https://github.com/Polymer/platform',
+ buildername='polymer linux',
+ scheduler='polymer-platform'
+ )
+ )

Powered by Google App Engine
This is Rietveld 408576698