scripts/slave/recipes/chromium.py - Issue 23889036: Refactor the way that TestApi works so that it is actually useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: License headers Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/blink_trybot.expected/win_fail_release_git.json ('k') | scripts/slave/recipes/chromium.expected/fail.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.py

diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py

index 8f49fa65914f3754df5e72bdba32042e9cf14f8b..211dab3733fb9fc78543bd314678e7157b5cc2bc 100644

--- a/scripts/slave/recipes/chromium.py

+++ b/scripts/slave/recipes/chromium.py

@@ -5,6 +5,7 @@

DEPS = [

'chromium',

'gclient',

+ 'platform',

'properties',

'python',

]

@@ -31,14 +32,9 @@ def GenSteps(api):

def GenTests(api):

for plat in ('win', 'mac', 'linux'):

for bits in (32, 64):

- yield 'basic_%s_%s' % (plat, bits), {

- 'mock': {'platform': {'name': plat}},

- 'properties': {'TARGET_BITS': bits},

- }

- yield 'fail', {

- 'step_mocks': {

- 'compile': {

- '$R': 1

- }

+ yield (

+ api.test('basic_%s_%s' % (plat, bits)) +

+ api.properties(TARGET_BITS=bits) +

+ api.platform(plat, bits)

+ )

+ yield api.test('fail') + api.step_data('compile', retcode=1)