scripts/slave/recipe_modules/step/api.py - Issue 23889036: Refactor the way that TestApi works so that it is actually useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/step/api.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: License headers Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/step/api.py

diff --git a/scripts/slave/recipe_modules/step/api.py b/scripts/slave/recipe_modules/step/api.py

index b25aa916aaf07e29dc1a7d901a760d3bf2958409..b806c2253f95b7624f051fca8a81ee371b68f6f4 100644

--- a/scripts/slave/recipe_modules/step/api.py

+++ b/scripts/slave/recipe_modules/step/api.py

@@ -3,6 +3,7 @@

# found in the LICENSE file.

from slave import recipe_api

+from slave import recipe_util

class StepApi(recipe_api.RecipeApi):

def __init__(self, *args, **kwargs):

@@ -37,10 +38,10 @@ class StepApi(recipe_api.RecipeApi):

assert isinstance(cmd, list)

if kwargs.get('abort_on_failure', False):

- @recipe_api.wrap_followup(kwargs)

+ @recipe_util.wrap_followup(kwargs)

def assert_success(step_result):

if step_result.presentation.status == 'FAILURE':

- raise recipe_api.RecipeAbort(

+ raise recipe_util.RecipeAbort(

"Step(%s) failed and was marked as abort_on_failure" % name)

kwargs['followup_fn'] = assert_success

« no previous file with comments | « scripts/slave/recipe_modules/raw_io/api.py ('k') | scripts/slave/recipe_modules/step/example.py » ('j') | no next file with comments »