Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: License headers Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 05c20d5b0437751e913be90cce33ea8a4a7e4261..7439be0f840a44c727f4813d7eb1e128050b98dc 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -49,7 +49,6 @@ class AndroidApi(recipe_api.RecipeApi):
s = spec.solutions[0]
s.name = repo_name
s.url = repo_url
- s.custom_vars = self.c.custom_vars
s.custom_deps = gclient_custom_deps or {}
if revision:
s.revision = revision
@@ -80,7 +79,7 @@ class AndroidApi(recipe_api.RecipeApi):
self._internal_dir, 'build', 'dump_app_manifest_vars.py'),
'-b', self.m.properties['buildername'],
'-v', self.m.path.checkout('chrome', 'VERSION'),
- self.m.json.output()]
+ '--output-json', self.m.json.output()]
)
app_manifest_vars = self.m.step_history.last_step().json.output
@@ -95,7 +94,7 @@ class AndroidApi(recipe_api.RecipeApi):
envsetup_cmd += ['--target-arch=%s' % self.c.target_arch]
cmd = ([self.m.path.checkout('build', 'env_dump.py'),
- self.m.json.output()] + envsetup_cmd)
+ '--output-json', self.m.json.output()] + envsetup_cmd)
yield self.m.step('envsetup', cmd, env=self.get_env())
env_diff = self.m.step_history.last_step().json.output
@@ -132,7 +131,7 @@ class AndroidApi(recipe_api.RecipeApi):
# TODO(sivachandra): Disable subannottations after cleaning up
# tree_truth.sh.
yield self.m.step('tree truth steps',
- [self.m.path.checkout('build', 'tree_truth.sh'),
+ [self.m.path.checkout('build', 'tree_truth.sh'),
self.m.path.checkout()] + repos,
allow_subannottations=True)
« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.py ('k') | scripts/slave/recipe_modules/chromium_android/config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698