Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 23889035: Move WEBCORE_NAVIGATOR macros defaults from the build system into a cpp file. (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move WEBCORE_NAVIGATOR macros defaults from the build system into a cpp file to reduce their's scope. Use the uname() call on all unix-like systems to determine the OS name not just on Linux to make the code more portable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157805

Patch Set 1 #

Patch Set 2 : Fix build (sorry). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M Source/core/core.gyp View 4 chunks +0 lines, -7 lines 0 comments Download
M Source/core/page/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/NavigatorID.cpp View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lgombos
base/sys_info_posix.cc is already using uname() for all Unix-like systems (except Android, but that case was ...
7 years, 3 months ago (2013-09-14 06:18:47 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-14 06:44:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23889035/1
7 years, 3 months ago (2013-09-14 06:44:15 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-14 06:58:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23889035/11001
7 years, 3 months ago (2013-09-14 14:18:31 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-15 01:08:20 UTC) #6
Message was sent while issue was closed.
Change committed as 157805

Powered by Google App Engine
This is Rietveld 408576698