Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2388903006: validate using nx to match bounds (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

validate using nx to match bounds Check the path against the bounds using Nx instead of straight scalars, R=mtklein@google.com BUG=skia:5541 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388903006 Committed: https://skia.googlesource.com/skia/+/0c52b1740e9714bdfaa111bec923a3f61a55d5b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/core/SkPathRef.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
caryclark
4 years, 2 months ago (2016-10-05 17:51:58 UTC) #4
mtklein_C
lgtm
4 years, 2 months ago (2016-10-05 17:54:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388903006/1
4 years, 2 months ago (2016-10-05 19:15:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:16:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0c52b1740e9714bdfaa111bec923a3f61a55d5b4

Powered by Google App Engine
This is Rietveld 408576698